WWidget: Disable touch events on macOS (fixing trackpad issues on Qt 6) #11870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
changed the title
|
Can you please reference the bug report from the code? |
|
Done |
|
Anything left to be done here? Looks like CI is stuck |
|
yep, something seems to be wrong with the coverage job, its pending on many of my PR's as well... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11869, an issue where Mac trackpad events wouldn't be recognized correctly on Qt 6.
Since there are no touchscreen Macs, disabling it until the issue is fixed in Qt seems like a workable solution.
Unfortunately, this fix cannot be tested as-is, since
maindoesn't build with Qt 6 yet, it has to be rebased ontoqt6_switch. Since it's sufficiently trivial, I would consider it safe to merge though.