Fix zeros in the first m4a chunk on Linux #11879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The SoundSourceProxyTest.firstSoundTest is here in action: |
Swiftb0y
approved these changes
Aug 28, 2023
uklotzde
approved these changes
Aug 28, 2023
| // Seek to codec frame boundaries if the frame size is fixed and known | ||
| if (m_pavStream->codecpar->frame_size > 0) { | ||
| seekIndex -= seekIndex % m_pavCodecContext->frame_size; | ||
| } | ||
| DEBUG_ASSERT(seekIndex >= 0); | ||
| DEBUG_ASSERT(seekIndex <= startIndex); |
There was a problem hiding this comment.
Keeping the second debug assertion wouldn't hurt.
|
Please readd the second debug assert, then I'll merge |
|
Rebased it back in. |
Swiftb0y
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts decoding of the first frame with the required preroll, going to < 1.
Before the reading of the peroll in this region has been skipped (clamped to zero).
Now the FFmpeg soundsource is head up with CoreAudio
Red Line before, Blue line after.
This fixes #11878
The issue has been discovered by a SoundSourceProxyTest.firstSoundTest in my pipeline.
Unfortunately this fix required a waveform re-analyzis if the first sound starts in this region (0 ... 23 ms)
This fix does not introduce an offset so that cue points are not shiftet.