-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Library track menu: show Hide action also in Playlist & Crates #11901
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Okay, that's because History shows all played tracks, incl. now hidden tracks, hence the view won't change after hiding tracks. This should go to the History root page. Showing a note after clicking Hide is cumbersome and requires setting another 'showHidefromHistoryHint' flag. |
Not sure how to proceed:
I prefer 1 but that may cause some confusion.
History doens't have a root view anymore 🤦 2 and 3. require more changes, e.g. subclass |
This PR is marked as stale because it has been open 90 days with no activity. |
This one has a conflict now. Sorry. |
Conflicts resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you.
Adds 'Hide from library' to Playlists (except History) and Crates features.
Test:
Del
hotkey should be shown in 'Remove ..' actions and should trigger only these actions.If there's no 'Remove ..' actions
Del
is used for 'Hide from library'Closes #9049