Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Library track menu: show Hide action also in Playlist & Crates #11901

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Aug 30, 2023

Adds 'Hide from library' to Playlists (except History) and Crates features.

Test:
Del hotkey should be shown in 'Remove ..' actions and should trigger only these actions.
If there's no 'Remove ..' actions Delis used for 'Hide from library'

Closes #9049

@ronso0

This comment was marked as outdated.

@ronso0 ronso0 marked this pull request as draft August 31, 2023 00:06
@ronso0
Copy link
Member Author

ronso0 commented Aug 31, 2023

Meeh, back to draft: the crates & playlist views are updated correctly, but in History views the action does nothing.

Okay, that's because History shows all played tracks, incl. now hidden tracks, hence the view won't change after hiding tracks.
We may show a hint to avoid confusion:
"History shows all tracks that have been played, including tracks that are marked hidden."

This should go to the History root page. Showing a note after clicking Hide is cumbersome and requires setting another 'showHidefromHistoryHint' flag.

@ronso0 ronso0 marked this pull request as ready for review August 31, 2023 12:29
@ronso0
Copy link
Member Author

ronso0 commented Aug 31, 2023

Not sure how to proceed:

  1. show Hide also in History (current implementation, no hint)
  2. show Hide also in History, show hint, set dontShowAgain flag
  3. don't show /disable Hide in History

I prefer 1 but that may cause some confusion.

This should go to the History root page.

History doens't have a root view anymore 🤦

2 and 3. require more changes, e.g. subclass PlaylistTableModel -> HistoryPlaylistTableModel, or alter BaseSqlTableModel::hideTracks, to show the hint only for the setlog feature.

Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Nov 30, 2023
@daschuer daschuer marked this pull request as draft January 24, 2024 22:51
@github-actions github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Jan 25, 2024
@ronso0 ronso0 changed the title Library track menu: show Hide action also in Playlist & Crates (fix) Library track menu: show Hide action also in Playlist & Crates Apr 19, 2024
@ronso0 ronso0 marked this pull request as ready for review April 19, 2024 21:04
@daschuer
Copy link
Member

This one has a conflict now. Sorry.

@daschuer daschuer marked this pull request as draft April 22, 2024 20:17
@ronso0
Copy link
Member Author

ronso0 commented Apr 22, 2024

Conflicts resolved.

@ronso0 ronso0 marked this pull request as ready for review April 22, 2024 23:50
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer added this to the 2.4.1 milestone Apr 23, 2024
@daschuer daschuer merged commit 3359f62 into mixxxdj:2.4 Apr 23, 2024
14 checks passed
@ronso0 ronso0 deleted the hide-tracks branch April 23, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants