Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagLib: Log import of metadata and cover art from file #11919

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/library/dlgcoverartfullsize.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ void DlgCoverArtFullSize::slotLoadTrack(TrackPointer pTrack) {

void DlgCoverArtFullSize::slotTrackCoverArtUpdated() {
if (m_pLoadedTrack) {
qDebug() << "DlgCoverArtFullSize: requestTrackCover" << m_pLoadedTrack->getLocation();
CoverArtCache::requestTrackCover(this, m_pLoadedTrack);
} else {
coverArt->setPixmap(QPixmap());
Expand Down
1 change: 1 addition & 0 deletions src/library/dlgtagfetcher.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@ void DlgTagFetcher::showProgressOfConstantTask(const QString& text) {
void DlgTagFetcher::loadCurrentTrackCover() {
m_pWCurrentCoverArtLabel->loadTrack(m_pTrack);
CoverArtCache* pCache = CoverArtCache::instance();
qDebug() << "DlgTagFetcher: requestTrackCover" << m_pTrack->getLocation();
pCache->requestTrackCover(this, m_pTrack);
}

Expand Down
15 changes: 8 additions & 7 deletions src/sources/metadatasourcetaglib.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,16 @@ MetadataSourceTagLib::importTrackMetadataAndCoverImage(
kLogger.warning()
<< "Nothing to import"
<< "from file" << m_fileName
<< "with type" << m_fileType;
<< "of type" << m_fileType;
return afterImport(ImportResult::Unavailable);
}
if (kLogger.traceEnabled()) {
kLogger.trace() << "Importing"
<< ((pTrackMetadata && pCoverImage) ? "track metadata and cover art" : (pTrackMetadata ? "track metadata" : "cover art"))
<< "from file" << m_fileName
<< "with type" << m_fileType;
}
kLogger.info() << "Importing"
<< ((pTrackMetadata && pCoverImage)
? "track metadata and cover art"
: (pTrackMetadata ? "track metadata"
: "cover art"))
<< "from file" << m_fileName
<< "of type" << m_fileType;

// Rationale: If a file contains different types of tags only
// a single type of tag will be read. Tag types are read in a
Expand Down
1 change: 1 addition & 0 deletions src/widget/wcoverart.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ void WCoverArt::slotReset() {

void WCoverArt::slotTrackCoverArtUpdated() {
if (m_loadedTrack) {
qDebug() << "WCoverArt: requestTrackCover" << m_loadedTrack->getLocation();
CoverArtCache::requestTrackCover(this, m_loadedTrack);
}
}
Expand Down
1 change: 1 addition & 0 deletions src/widget/wspinnybase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ void WSpinnyBase::slotLoadingTrack(TrackPointer pNewTrack, TrackPointer pOldTrac

void WSpinnyBase::slotTrackCoverArtUpdated() {
if (m_pLoadedTrack) {
qDebug() << "WSpinnyBase: requestTrackCover" << m_pLoadedTrack->getLocation();
CoverArtCache::requestTrackCover(this, m_pLoadedTrack);
}
}
Expand Down
Loading