DlgPrefSound: Fix fetching of sample rate #11951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
requested changes
Sep 9, 2023
|
thank you, please run pre-commit and squash. |
fwcd
force-pushed
the
fix-audio-buffer-samplerate
branch
from
57e4ec3
to
a4a401c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11949, i.e. causes audio buffer sizes to be displayed correctly again:
The issue was that the sample rate combo box was still queried for a double, while underlying data already used the
SampleRatetype, causing it to presumably default to 0 and thus result in divisions by zero. This was likely an oversight in #11904.