-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log warning if deprecated control is used #11972
Conversation
should we raise the severity conditionally (eg add a member to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. though its not my turn to merge IMO since it was my suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you.
I think this causes a regresson, in case the original CO is not deprecteded but are just short hands for the bulky original:
Can we store a deprecated flag along with the alias to target that? |
But these CO are deprecated, since Version 2.0.0. See https://manual.mixxx.org/2.3/en/chapters/appendix/mixxx_controls#control-[ChannelN]-filterLow Let's just replace these occurrences with the recommended, non-deprecated alternative. |
This will make it easier to find uses of deprecated controls. Idea blatantly stolen from @Swiftb0y who suggested it here: #11960 (comment)