CO Renaming (Pt. 3): Add ControlPotMeter aliasing and move audio_latency_* COs

[Holzhaus]

This PR is part of the ongoing effort to remove offensive language from the Mixxx codebase (#11931).

I had to add proper support for adding aliases to ControlPotMeter due to audio_latency_usage and audio_latency_overload. However, I'm wondering why these controls are ControlPotMeter objects in the first place. These should be read-only IIRC, so there is no need for all these setter-COs.

Old Name	New Name	Alias?
[Master],audio_latency_usage	[App],audio_latency_usage	✔️
[Master],audio_latency_overload	[App],audio_latency_overload	✔️
[Master],audio_latency_overload_count	[App],audio_latency_overload_count	✔️

[Holzhaus]

However, I'm wondering why these controls are ControlPotmeter objects in the first place. These should be read-only IIRC, so there is no need for all these setter-COs.

I couldn't find any use of the additional ControlPotmeter COs, and I think they don't make sense. I converted audio_latency_usage and audio_latency_overload into regular COs.

[Swiftb0y]

this is duplicated across the constructor, I'm worried that we might forget to update both places in case we add another suffix, would this be possible to deduplicate?

[Holzhaus]

I don't really know how to do that in an elegant way. I pushed a little helper function to make the ConfigKey creation less verbose though.

[Swiftb0y]

Well, I came up with this: https://compiler-explorer.com/z/xxE83Gf8r
I find it very elegant, just don't know how easy it is to understand.
Frankly, now that I've written it, I don't think we should use it here. Its very seldom that we would add another suffix for ControlPotMeter and the complexity doesn't warrant it.

[Swiftb0y]

Next best thing would just be a comment in both parts reminding the reader of the other part.

[Holzhaus]

a3ca5ea

[ronso0]

I couldn't find any use of the additional ControlPotmeter COs, and I think they don't make sense. I converted audio_latency_usage and audio_latency_overload into regular COs.

Great! So we don't need Potmeter aliasing at all? If yes, why keep that commit?

[Holzhaus]

I couldn't find any use of the additional ControlPotmeter COs, and I think they don't make sense. I converted audio_latency_usage and audio_latency_overload into regular COs.

Great! So we don't need Potmeter aliasing at all? If yes, why keep that commit?

There are other COs that might need it. We didn't rename all of them.

And I thinks it's good if addAlias "just works". Without that commit, if we later add an alias to an ControlPotmeter, it would work but just alias the main control, not the other ones and we might not notice it.

[Swiftb0y]

lgtm otherwise, thank you

[Swiftb0y]

LGTM, thank you.

[Holzhaus]

Merge?

[Holzhaus]

Thanks.