Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang-tidy wanings a and a missng initalization #12003

Merged
merged 2 commits into from
Sep 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/control/controlcompressingproxy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace {
constexpr int kMaxNumOfRecursions = 128;
}
} // namespace

// Event queue compressing proxy
CompressingProxy::CompressingProxy(const ConfigKey& key,
Expand Down
2 changes: 1 addition & 1 deletion src/control/controlindicator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace {
const QString kAppGroup = QStringLiteral("[App]");
}
} // namespace

ControlIndicator::ControlIndicator(const ConfigKey& key)
: ControlObject(key, false),
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/controlpickermenu.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace {
const QString kAppGroup = QStringLiteral("[App]");
}
} // namespace

ControlPickerMenu::ControlPickerMenu(QWidget* pParent)
: QMenu(pParent) {
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/delegates/midioptionsdelegate.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const QList<MidiOption> kMidiOptions = {
MidiOption::FourteenBitLSB,
};

}
} // namespace

MidiOptionsDelegate::MidiOptionsDelegate(QObject* pParent)
: QStyledItemDelegate(pParent) {
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/midi/portmidicontroller.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace {
const QString kUnknownControllerName = QStringLiteral("Unknown PortMidiController");
}
} // namespace

PortMidiController::PortMidiController(const PmDeviceInfo* inputDeviceInfo,
const PmDeviceInfo* outputDeviceInfo,
Expand Down
1 change: 1 addition & 0 deletions src/effects/backends/lv2/lv2effectprocessor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

LV2EffectProcessor::LV2EffectProcessor(LV2EffectManifestPointer pManifest)
: m_pManifest(pManifest),
m_LV2parameters(nullptr),
m_pPlugin(pManifest->getPlugin()),
m_audioPortIndices(pManifest->getAudioPortIndices()),
m_controlPortIndices(pManifest->getControlPortIndices()) {
Expand Down
2 changes: 1 addition & 1 deletion src/effects/presets/effectpresetmanager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace {
const QString kEffectDefaultsDirectory = "/effects/defaults";
}
} // namespace

EffectPresetManager::EffectPresetManager(UserSettingsPointer pConfig,
EffectsBackendManagerPointer pBackendManager)
Expand Down
2 changes: 1 addition & 1 deletion src/engine/controls/loopingcontrol.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ constexpr mixxx::audio::FrameDiff_t kMinimumAudibleLoopSizeFrames = 150;
bool positionNear(mixxx::audio::FramePos a, mixxx::audio::FramePos target) {
return a.isValid() && a > target - 1 && a < target + 1;
}
}
} // namespace

double LoopingControl::s_dBeatSizes[] = { 0.03125, 0.0625, 0.125, 0.25, 0.5,
1, 2, 4, 8, 16, 32, 64, 128, 256, 512 };
Expand Down
2 changes: 1 addition & 1 deletion src/engine/enginemixer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

namespace {
const QString kAppGroup = QStringLiteral("[App]");
}
} // namespace

EngineMixer::EngineMixer(
UserSettingsPointer pConfig,
Expand Down
2 changes: 1 addition & 1 deletion src/library/library.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ namespace {

const mixxx::Logger kLogger("Library");

} // anonymous namespace
} // namespace

using namespace mixxx::library::prefs;

Expand Down
2 changes: 1 addition & 1 deletion src/library/trackset/setlogfeature.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

namespace {
constexpr int kNumToplevelHistoryEntries = 5;
}
} // namespace

using namespace mixxx::library::prefs;

Expand Down
Loading