Search: also search for half & double BPM #12070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
force-pushed
the
search-bpm-half-double
branch
from
807722c
to
9327cae
Compare
Closed
|
Meeh, seems I broke too many use cases. |
6 tasks
|
new attempt in #12072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpm:Nnow also finds N*2 and N/2, the latter with a range of prev - next integer in case N is odd, considering electronic music with mostly integer BPM.In case the behaviour is unexpected and disturbing for users we may add an option to Preferences > Library > Search (default on).
This may be extended / rewritten for range operators
n-mif desired (fuzzy BPM match), and in that case probably better moved to new FilterNodeBpmFilterNode.If wanted this for years and since it's working I'll use it, but I can't tell when I'll finish it (tests, polishing). Feel free to adopt/edit if there's a demand.