Skins / Qt6: menu icon position fix

[ronso0]

... + some cleanup

Menu icons are are a bit off to the left.

---

With Qt6 the context menus should look like this:
(yes, this is expected to break styles with Qt5)




(yes, the shortcut Ctrl+a still overlaps "Select all")

Please verify on all OS and in all skins. Thanks!

• main menu (menubar)
• table header menu
• track menu (decks & library), especially Crates menu
• sidebar menu, especially Crates menu
• edit fields menu (searchbar, track table inline editing, beatsize spinboxes etc.)

[JoergAtGithub]

This is how it looks on Windows 11 with this PR:



I wasn't able to edit the track title in the library (BTW, should there be a tooltip, which explains in-place editing?)

Why is this menu in English language and all other in German?

[ronso0]

Thanks @JoergAtGithub

You only need to post screenshots if you notice significant deviation from my screenshots.

Why is this menu in English language and all other in German?

Good question. On Linux, the selected locale is applied to all menus.
Not a regression of this PR, I just touched the stylesheets. Please file an Issue.

[ronso0]

Thanks @JoergAtGithub

You only need to post screenshots if you notice significant deviation from my screenshots.

Why is this menu in English language and all other in German?

Good question. On Linux, the selected locale is applied to all menus.
Not a regression of this PR, I just touched the stylesheets. Please file an Issue.

[ronso0]

BTW, should there be a tooltip, which explains in-place editing?

Maybe, though I have no idea where that would go. Having it appended to every cell's tooltip seems a bit annoying, especially if you're already aware of the feature.
I think this is part of the meta issue: how to properly introduce all those fancy UI features, i.e. increase discoverability of features like track drag'n'drop, double-click on track labels, skin settings and what not.

[github-actions]

This PR is marked as stale because it has been open 90 days with no activity.

[JoergAtGithub]

Please fix the conflicts

[ronso0]

I rebased onto 2.5.
Please check again on all targets:

• table header menu
• any QLineEdit menu (search, beat spinboxes, table inline editors, etc.)
• track menu -> crates
• sidebar -> crate name menu (with checkbox)
• "search related tracks" menu
• ...

[JoergAtGithub]

Overall it looks good on Windows11 (Qt6.5.3 from VCPKG). But the checked checkboxes look slightly smaller than the unchecked and have rounder corners.

100% Zoom:

200% Zoom:

[daschuer]

I can confirm the issue is fixed:

I cannot confirm the different checkbox sizes. @JoergAtGithub is this a regression form this PR?

[JoergAtGithub]

The differnent checkbox size is not a regression by this PR!

[ronso0]

Okay, so we need a check on macOS @m0dB @foss- @fwcd (?)

I'll take a look at the checkbox issue on Windows but will probably open a separate PR for this.

[foss-]

Crate checkbox + contextual menu for crate. There are no icons in the menu-bar options on macOS.
Version tested: 2.5-alpha-410-g7d4dcb92b7 (HEAD)

[daschuer]

Thank you. This means macOS is not affected and we can merge.