Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParametricEQEffect: Fix typo in description #12217

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Oct 25, 2023

Just a minor typo I've come across.

@ronso0
Copy link
Member

ronso0 commented Oct 25, 2023

I assume this didn't affect translations.
In order to keep existing translations, it is preferred to change the source string in transifex (note that I have no experience with this):
https://help.transifex.com/en/articles/6236820-edit-source-strings-online#h_7e60a9b609

edit Thanks for taking care, of course!

@ronso0 ronso0 marked this pull request as draft October 25, 2023 11:47
@ronso0
Copy link
Member

ronso0 commented Oct 25, 2023

tr wizard @daschuer what is your opinion?

@daschuer
Copy link
Member

This string is translated in some languages,
Better a redundant "n" in one language than an untranslated string.
Let's postpone this fix to 2.5.

@daschuer
Copy link
Member

... We cannot change the source text, because it is also the lookup key.

@ronso0
Copy link
Member

ronso0 commented Oct 25, 2023

Sounds resonable, though did you take a look at the article I linked above?
Seems there is a facility for exactly this case.

@fwcd
Copy link
Member Author

fwcd commented Oct 25, 2023

Can we change the key for all languages?

@ronso0
Copy link
Member

ronso0 commented Oct 25, 2023

I don't know, I'm not familiar with the Transifex/lupdate workflow.
Here's the intro to the new'Update source' function added in July this year. it's available via Transifex User Interface (UI), Transifex API and Transifex Go CLI
https://community.transifex.com/t/introducing-enhanced-resource-updating-in-transifex/3503

Here the documentation for the 'new' CLI client:
https://github.com/transifex/cli#pushing-files-to-transifex

--keep-transations: If present, translations of source strings with the same key whose content changes will not be discarded. This can also be set on a per-resource level in the configuration file.

@daschuer daschuer marked this pull request as ready for review January 21, 2024 21:35
@daschuer
Copy link
Member

Ok, I will merge that now and fix the translations manually on Transifex.

@daschuer daschuer merged commit 78e737a into mixxxdj:2.4 Jan 21, 2024
13 checks passed
@ronso0
Copy link
Member

ronso0 commented Jan 21, 2024

Thank you very much!

@daschuer
Copy link
Member

Done.

@fwcd fwcd deleted the fix-param-eq-typo branch January 21, 2024 22:05
@daschuer daschuer added this to the 2.4.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants