Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindVorbis: Link ogg in static builds #12297

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Nov 12, 2023

We have to link libogg into libvorbis when building static binaries on Linux, see e.g. this build:

/usr/bin/ld: /home/runner/work/m1xxx/m1xxx/vcpkg/installed/x64-linux/lib/libvorbis.a(block.c.o): in function `vorbis_block_init':
block.c:(.text+0x3f8): undefined reference to `oggpack_writeinit'
/usr/bin/ld: block.c:(.text+0x415): undefined reference to `oggpack_writeinit'
/usr/bin/ld: /home/runner/work/m1xxx/m1xxx/vcpkg/installed/x64-linux/lib/libvorbis.a(block.c.o): in function `vorbis_block_clear':
block.c:(.text+0x58a): undefined reference to `oggpack_writeclear'
/usr/bin/ld: /home/runner/work/m1xxx/m1xxx/vcpkg/installed/x64-linux/lib/libvorbis.a(analysis.c.o): in function `vorbis_analysis':
analysis.c:(.text+0x48): undefined reference to `oggpack_reset'
...

@fwcd fwcd marked this pull request as ready for review November 12, 2023 22:15
@fwcd
Copy link
Member Author

fwcd commented Nov 12, 2023

Seems to work, there are no more oggpack_* linker errors in this build.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daschuer daschuer merged commit 18e17c2 into mixxxdj:main Nov 13, 2023
11 checks passed
@fwcd fwcd deleted the linux-static-vorbis-ogg branch November 13, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants