common-hid-packet-parser.js: Fix regression for resolving decks in getActiveFieldGroup #12406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the behavior of resolveGroup And adds warnings at various callers, for the case that resolveGroup returns undefined
ywwg
approved these changes
Dec 8, 2023
|
@ywwg It would be great, if you would merge this soon! |
|
This works! thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the old behavior of getActiveFieldGroup without altering the behavior of resolveGroup
And adds warnings at various callers, for the case that resolveGroup returns undefined
This fix a regression introduced in: #12102
Closes: #12208