A small fix to .desktop file that improves Gnome dock integration on #12424
Conversation
linux. The issue was that gnome dock couldn't pick right icon for the app and it wasn't possible to pin Mixxx to the dock. Both fixed.
|
There's little info on thi attribute @uncleeugene Which distro + version do you use? |
|
FWIW on Ubuntu 20.04 (with xfwm4) only a few .desktop files have this set (50 of ~300), though all apps show the app icon in the taskbar and app switcher. |
Please extract these unrelated changes into a separate PR. |
? |
|
Yes, here on Manjaro most of .desktop files live just well without that line. yet still it helped. The issue was that upon starting Mixxx gnome drew some default gear-like icon in dock, and there was just one option in context menu - "show window". Quick google shown that it is kinda like gnome couldn't deduce which window it is and this line will help it. |
|
Thank you for the fix. Even though this is only one line we like to have your formal permission to distribute you changes with Mixxx. So please sign: https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ Thank you. |
Doesn't matter. The modification is completely unrelated to a controller mapping PR where you would never expect such a change. |
I made this commit to mapping PR by mistake but then i reverted it. This PR is just for this feature, as far as i can say. |
|
and comment here when done.
Done! |
|
That's what I see in Looking Glass on Wayland when starting Mixxx from the command line or with the current desktop launcher:
The icon is shown both in the dock and in the task switcher. |
@uncleeugene Please file a bug report, maybe we can work it out. |
| @@ -13,4 +13,5 @@ Terminal=false | |||
| Icon=mixxx | |||
| Type=Application | |||
| StartupNotify=true | |||
| StartupWMClass=org.mixxx.mixxx | |||
There was a problem hiding this comment.
Why org.mixxx.mixxx instead of org.mixxx.Mixxx like the file name?
Did you check the actual WM Class of the window using xprop or Looking Glass? My system always shows Mixxx which differs from the proposed entry here.
There was a problem hiding this comment.
My bad, didn't notice the case. Yet it doesn't work with capital letter. Just rechecked.
Yes, i've checked, just commented on that.
|
On X.org: I don't see any justification for the newly proposed string. |
|
Tried to remove the line. Left the pinned icon in dock. Without the line Mixxx starts just next to the pinned icon.
Looking glass shows "wmclass: org.mixxx.mixxx" and "untracked". When i put the line back everything starts working as it's supposed to do, and Looking Glass shows this:
I will file a bug report, but maybe this information will help resolve the issue. |
|
I recommend to first collect |
|
Both Qt5 and Qt6 builds show the same WM Class values on Fedora. This couldn't be the issue. |
|
Btw, your screenshot does not show the original Mixxx icon. |
|
@uncleeugene did you build Mixxx yourself or are you using distro packages/third party builds? Maybe they patched something which results in the different wmclass string? |
Yes, it is gnome theming thing. |
I built it myself. I don't remember whether i pulled it from github or through AUR though. I will check this evening. |
|
Ok, thank you for investigation. Lets merge it ans see if it is an improvement. |
|
I think we should indeed have waited for @uncleeugene & others to provide more info. FWIW, Mixxx 2.4-beta from the ppa on Ubuntu 20.04.5 In the app launcher the icon is not what I expected |
|
@ronso0 Thanks for your investigations. The way how valuable feedback and valid concerns are ignored is confusing 👀 |
this is also used as icon for the QML windows, so I assumed it's some default icon used for the 'Music' apps category in Ubuntu Studio. Turns out this is the icon from the Papyrus icon theme (which I don't use) and obviously my current icon theme doens't provide a With Breeze theme by KDE I get this X) This is with xfce 4.14 btw I'm don't know if it's intended but I'd prefer if Mixxx would override those 'custom' icons. edit I'll fetch from the ppa later on to check whether this PR makes a difference. |
|
Mixxx built with Qt6 running natively on Wayland without the
The WM Class is indeed |
Qt5 on Wayland is not working properly. At least not in Mixxx. This is a known issue that could only be resolved by building Mixxx for Qt6 instead. Whoever packages a Qt5 build of Mixxx in a way that doesn't enable the XWayland fallback at runtime is doing it wrong. |
I don't think distro maintainers would like that. If they think that some icon or rather icon theme is better than our icon, we should let them customize. We don't need to do marketing by forcing our icon everywhere. Anyways, not important. |
|
True, probably they woldn't like. I know that the official Mixxx is not optimal, but IMO it leaves enough room to fit it into themes. |
Yup, that's a problem, but on the side of the theme designers. If they create a theme that is totally distinct from other themes, its their the fault of their bad design work... I think users are smart enough not to blame us when they install a 3rd party theme that makes their applications unrecognizable. |
|
@Swiftb0y Any ideas how to fix the Wayland/XWayland inconsistencies? I can confirm the issues after I was switched back to the Wayland backend for my Qt6 build. |
|
I'm not afraid of Mixxx being blamed. It would just be nice to have a somewhat consistent icon across themes. |
No idea... I'd blame it on Gnome. I don't find a missing app icon to be severe enough to care about... |
linux.
The issue was that without that line gnome dock couldn't pick right icon for Mixxx window and it wasn't possible to pin Mixxx to the dock. Both fixed.