(fix UX) Library: add feedback to directory operations (add, remove, relink) #12436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
commented
Dec 15, 2023
| InvalidOrMissingDirectory, | ||
| UnreadableDirectory, | ||
| SqlError, | ||
| }; |
There was a problem hiding this comment.
To reduce tr strings for the dialogs we could merge all ~Result types and forward them to a dialog function in Library.
ronso0
commented
Dec 15, 2023
| // TODO: Move this function out of the DAO | ||
| QList<RelocatedTrack> relocateDirectory( | ||
| std::pair<RelocateResult, QList<RelocatedTrack>> relocateDirectory( |
There was a problem hiding this comment.
This could also be a struct to make it more compact, but that appearantly that requires some extras to make it work with std::tie in TrackCollection.
Didn't test it.
struct RelocateResult {
Result result;
QList<RelocatedTrack> trackList;
template<typename T, typename U>
operator std::tuple<T, U>();
};
…issing It is checked whether the new directory exists beforehand, therefor the checks below can not be tricked and no inconsistences should arise
ronso0
force-pushed
the
lib-add-dir-error
branch
from
8ac56eb
to
f1d2278
Compare
acolombier
approved these changes
Apr 12, 2024
ronso0
force-pushed
the
lib-add-dir-error
branch
from
f1d2278
to
3889305
Compare
|
I rebased onto main to resolve the conflicts (should have merged main instead : | ). |
|
argh, missed some comments. I'll revert to last good state and merge main. |
ronso0
force-pushed
the
lib-add-dir-error
branch
from
3889305
to
491cbf2
Compare
|
Done. |
ronso0
changed the title
|
Oh sorry, a conflict has developed after @acolombier review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves user feedback for library directory action in Library preferences (add, relink, remove) and when adding a directory in the Computer feature by showing appropriate message popups.
Fixes #10481