Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LateNight: fix xfader icons in samplers and aux units #12477

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Dec 29, 2023

The samplers xfader icns were only half the size, so doubling the size and setting the 1:1 viewbox attribute does not work for icons set in xml templates via

<State>
  <Number>2</Number>
  <Pressed scalemode="STRETCH_ASPECT">skins:LateNight/<Variable name="BtnScheme"/>/buttons/btn__xfader_sampler_right.svg</Pressed>
  <Unpressed scalemode="STRETCH_ASPECT">skins:LateNight/<Variable name="BtnScheme"/>/buttons/btn__xfader_sampler_right.svg</Unpressed>
</State>

it has the contrary effect, exactly what daschuer noticed here #12364 (comment)
grafik

@m0dB please check if that looks okay on your machine.

Addionally, I fixed blurred edges caused by a pixel offset in double-size icons (Aux xfader icons).

@ronso0 ronso0 added this to the 2.4.0 milestone Dec 29, 2023
@github-actions github-actions bot added the skins label Dec 29, 2023
@m0dB
Copy link
Contributor

m0dB commented Dec 30, 2023

At a first glance it looks good, but some icons are now huge: 253px x 300px . Is this intentional?

@ronso0
Copy link
Member Author

ronso0 commented Dec 30, 2023

Oh, I didn't look at the diff. The width and height attributes were removed (now both "0") as well as the closing </svg>.
I'll fix it.

@ronso0
Copy link
Member Author

ronso0 commented Dec 30, 2023

Fixed. @m0dB please take anoter look.

@m0dB m0dB merged commit 40a6055 into mixxxdj:2.4 Dec 30, 2023
13 checks passed
@m0dB
Copy link
Contributor

m0dB commented Dec 30, 2023

LGTM, merged!

@ronso0 ronso0 deleted the latenight-xfader-buttons branch December 30, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants