Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pitch Shift effect: set Meta default to 0.5 (center) #12481

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Pitch Shift effect: set Meta default to 0.5 (center) #12481

merged 1 commit into from
Dec 30, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Dec 30, 2023

matches the defaults of both linked knob parameters

Swiftb0y
Swiftb0y approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, noticed that as well. LGTM. Thank you.

@Swiftb0y Swiftb0y merged commit 5714c63 into mixxxdj:2.4 Dec 30, 2023
13 checks passed
@ronso0 ronso0 deleted the pitch-shift-meta-default branch December 30, 2023 11:07
@daschuer daschuer added this to the 2.4.0 milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ronso0 @Swiftb0y @daschuer