gradually "compact" the markers if the waveform height is reduced

[m0dB]

To address this issue: #12273 (comment)

[JoergAtGithub]

In the last case you can't click on the marker anymore. A small section of should be always visible.

[fwcd]

In the last case you can't click on the marker anymore. A small section of should be always visible.

Sounds reasonable, though from what I can tell, the markers in the "main" waveform aren't clickable, only the preview ones are (or am I missing something?)

[JoergAtGithub]

In the last case you can't click on the marker anymore. A small section of should be always visible.

Sounds reasonable, though from what I can tell, the markers in the "main" waveform aren't clickable, only the preview ones are (or am I missing something?)

Look at this example, a track from a DJ download pool prepared with Serato Hotcues and Saved Loops, which you can't access anywhere else in the Mixxx UI, because Mixxx skins have only 8 Hotcue-Buttons:

TrackWithSeratoHotcues.mp4

[fwcd]

Ah nice, TIL, didn't know this worked differently for hotcues. Though I think it's reasonable to prioritize glanceability over editability for the compact layout, anyone interested in editing several hotcues would probably work with a larger view anyway.

[fwcd]

Did some quick testing, looks and works great!

[m0dB]

Great! Would you adjust the threshold or do you think it's fine link this? (I personally think it could kick in a little bit sooner)

I disagree with @JoergAtGithub's assessment that "a small section of should be always visible", and IIUC @fwcd also thinks this isn't necessary. Indeed, if you want make the waveforms small like this, you probably aren't particularly interested in the markers at that point. But my opinion on this is not a very strong one, so maybe after merging we can ask what people think and adjust it if a majority prefers to keep a small section visible.

[JoergAtGithub]

Let's discuss this on Zulip, to get more opinions

[m0dB]

I just tried it out with a minimum increment of 2 and actually I like it better! It's just 2 pixels but in exchange you know that there is more than one marker there.

[fwcd]

I think leaving a small section visible is a fine compromise, it hints at the user that there's more content behind the marker even if it's not shown. If the user is interested, they can expand the view as needed.

(I just typed out the same thing, what a coincidence haha)

[m0dB]

Done!

[fwcd]

Thanks! Since this is a rather small, but useful UI improvement over the status quo, and the concerns by @JoergAtGithub have been addressed, I'll go ahead and merge it. Tweaking the thresholds or making them configurable could be done in a future PR, if desired, but this is a good default for now.