-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Changelog for 2.4 #12507
Update Changelog for 2.4 #12507
Conversation
f64d326
to
7465ca3
Compare
c72c7ba
to
869b505
Compare
Is missing #12376 |
No, that was for |
Aaah, so all new features go to main, so it's just in 2.5-alpha onward? I wonder how much there is to go wrong with it, but cool, fair enough if there is a process to be stuck to. |
At least the raw version I have started with was auto-generated by the attached script. In the next step after merge we will remove entries not important to users. That can also go wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm -- we can create a reduced list from this for the blog post and do language correction and refinement there.
a5ef517
to
19516ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is my first run, stopped above the Waveforms section
CHANGELOG.md
Outdated
@@ -394,22 +498,24 @@ | |||
* Fix segfault during Mixxx shutdown due to a stale controller connection [#4476](https://github.com/mixxxdj/mixxx/pull/4476) [#10553](https://github.com/mixxxdj/mixxx/issues/10553) | |||
* Components JS: Fix syncbutton [#4329](https://github.com/mixxxdj/mixxx/pull/4329) | |||
* Components JS: Add script.posMod for euclidean modulo [#11415](https://github.com/mixxxdj/mixxx/pull/11415) | |||
* Components JS: make JogWheelBasic correctly switch which deck it controls [#11913](https://github.com/mixxxdj/mixxx/pull/11913) [#11867](https://github.com/mixxxdj/mixxx/issues/11867) | |||
* Added Trace for the mapping connections, to allow JS profiling [#4766](https://github.com/mixxxdj/mixxx/pull/4766) | |||
* Fix crash when using `midi.sendShortMsg` and platform vnc [#4635](https://github.com/mixxxdj/mixxx/pull/4635) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that one went into 2.3 before 2.3.6 was released
Found only small issues. |
3dfbced
to
d1c14be
Compare
Thank you for the detailed review! |
We had a brief discussion how to proceed with this bulky long changelog. A consensus was to not put much extra hours to it for polishing, because no user will read it line by line. In earlier entries we have removed developer topics. I think I will at least do this to match the style of previous entries after merge. Ideas? |
Sute, except mapping dev topics I assume. |
d1c14be
to
167f087
Compare
Co-authored-by: ronso0 <ronso0@mixxx.org>
167f087
to
d7be577
Compare
tools/createChangelog.py
Outdated
@@ -0,0 +1,24 @@ | |||
import git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a short docstyle comment to describe what this script does? (does it update the changelog or create it from scratch? when should it be used? etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. waiting for @ronso0 to approve or resolve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's remove the redundant 'Effects' prefix.
[#12289](https://github.com/mixxxdj/mixxx/issues/12289) | ||
[#11094](https://github.com/mixxxdj/mixxx/issues/11094) | ||
* Different, language depending library sorting on macOS | ||
[#12517](https://github.com/mixxxdj/mixxx/issues/12517) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember we came across an issue recently that we wanted to add to 'known issues' (but we didn't think of this place). I added the Changelog label and added it to the 2.4 milestone, but I can't find it anymore...
Maybe someone else remembers what that was.
I think @fwcd and/or @m0dB were involved.
Co-authored-by: ronso0 <ronso0@mixxx.org>
5ee8f85
to
1225ace
Compare
Thank you, looks good! |
This adds another 304 lines to the changelog.
Thank you for all the work and love that is hidden behind each line!
This is the raw version of the Changelog with all PRs and almost all Issues referenced.
I like to merge it to make the next meld down step to a hand-able size visible in a diff.
Please check also the rendered md version.