Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Changelog for 2.4 #12507

Merged
merged 10 commits into from
Jan 14, 2024
Merged

Update Changelog for 2.4 #12507

merged 10 commits into from
Jan 14, 2024

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Jan 4, 2024

This adds another 304 lines to the changelog.
Thank you for all the work and love that is hidden behind each line!

This is the raw version of the Changelog with all PRs and almost all Issues referenced.
I like to merge it to make the next meld down step to a hand-able size visible in a diff.

Please check also the rendered md version.

@daschuer daschuer changed the base branch from main to 2.4 January 4, 2024 07:34
@mxmilkiib
Copy link
Contributor

Is missing #12376

@ronso0
Copy link
Member

ronso0 commented Jan 5, 2024

Is missing #12376

No, that was for main, not 2.4

@mxmilkiib
Copy link
Contributor

Aaah, so all new features go to main, so it's just in 2.5-alpha onward? I wonder how much there is to go wrong with it, but cool, fair enough if there is a process to be stuck to.

@daschuer
Copy link
Member Author

daschuer commented Jan 5, 2024

At least the raw version I have started with was auto-generated by the attached script.
All the sorting and matching with issue numbers is a manual process, which can go wrong.

In the next step after merge we will remove entries not important to users. That can also go wrong.
Help is welcome.

@ywwg ywwg added this to the 2.4.0 milestone Jan 9, 2024
@ywwg ywwg added the blocker label Jan 9, 2024
Copy link
Member

@ywwg ywwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- we can create a reduced list from this for the blog post and do language correction and refinement there.

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is my first run, stopped above the Waveforms section

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
@@ -394,22 +498,24 @@
* Fix segfault during Mixxx shutdown due to a stale controller connection [#4476](https://github.com/mixxxdj/mixxx/pull/4476) [#10553](https://github.com/mixxxdj/mixxx/issues/10553)
* Components JS: Fix syncbutton [#4329](https://github.com/mixxxdj/mixxx/pull/4329)
* Components JS: Add script.posMod for euclidean modulo [#11415](https://github.com/mixxxdj/mixxx/pull/11415)
* Components JS: make JogWheelBasic correctly switch which deck it controls [#11913](https://github.com/mixxxdj/mixxx/pull/11913) [#11867](https://github.com/mixxxdj/mixxx/issues/11867)
* Added Trace for the mapping connections, to allow JS profiling [#4766](https://github.com/mixxxdj/mixxx/pull/4766)
* Fix crash when using `midi.sendShortMsg` and platform vnc [#4635](https://github.com/mixxxdj/mixxx/pull/4635)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that one went into 2.3 before 2.3.6 was released

CHANGELOG.md Outdated Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Jan 9, 2024

Found only small issues.
Please remove
[#4255](https://github.com/mixxxdj/mixxx/pull/4455)

@daschuer daschuer force-pushed the 2.4.0_changelog branch 2 times, most recently from 3dfbced to d1c14be Compare January 10, 2024 07:26
@daschuer
Copy link
Member Author

Thank you for the detailed review!

@daschuer
Copy link
Member Author

We had a brief discussion how to proceed with this bulky long changelog. A consensus was to not put much extra hours to it for polishing, because no user will read it line by line. In earlier entries we have removed developer topics. I think I will at least do this to match the style of previous entries after merge. Ideas?

@ronso0
Copy link
Member

ronso0 commented Jan 10, 2024

Sute, except mapping dev topics I assume.

Co-authored-by: ronso0 <ronso0@mixxx.org>
@@ -0,0 +1,24 @@
import git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a short docstyle comment to describe what this script does? (does it update the changelog or create it from scratch? when should it be used? etc)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@daschuer
Copy link
Member Author

Ready.

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. waiting for @ronso0 to approve or resolve.

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's remove the redundant 'Effects' prefix.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
[#12289](https://github.com/mixxxdj/mixxx/issues/12289)
[#11094](https://github.com/mixxxdj/mixxx/issues/11094)
* Different, language depending library sorting on macOS
[#12517](https://github.com/mixxxdj/mixxx/issues/12517)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember we came across an issue recently that we wanted to add to 'known issues' (but we didn't think of this place). I added the Changelog label and added it to the 2.4 milestone, but I can't find it anymore...

Maybe someone else remembers what that was.
I think @fwcd and/or @m0dB were involved.

daschuer and others added 2 commits January 14, 2024 17:14
Co-authored-by: ronso0 <ronso0@mixxx.org>
@ronso0
Copy link
Member

ronso0 commented Jan 14, 2024

Thank you, looks good!

@ronso0 ronso0 merged commit d01d841 into mixxxdj:2.4 Jan 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants