Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add qt6-qpa-plugins to dependencies #12549

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jan 11, 2024

Should fix #12525

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This need to go also to the tools/Debian... And packaging/Debian/control.in

Unfortunately it is conflicting with
#12535
Targeting a similar issue.

Should I take over, on top of that and you review and merge?

@ronso0
Copy link
Member Author

ronso0 commented Jan 11, 2024

I thought about control.in first and noticed that it uses CPACK_DEBIAN_PACKAGE_DEPENDS populated in cmakelist. It's not a build dependency IIUC.

Please take over if you're sure it's required.

@daschuer
Copy link
Member

Oh, yes, thank you for the head up. I think I need to adjust my PRs accordingly.

@daschuer daschuer merged commit ee0e236 into mixxxdj:main Jan 12, 2024
12 checks passed
@ronso0 ronso0 deleted the qt6-ubuntu-xcb-fix branch January 12, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.5-alpha won't start on Uuntu 22.04 due to missing Qt platform plugins
2 participants