Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shade: Overlay for loop hot cues #12637

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

daschuer
Copy link
Member

Here the Shade version:

grafik

There is a unrelated issue to this PR that the button is not colored/Styled after setting the loop.

@github-actions github-actions bot added the skins label Jan 23, 2024
@daschuer daschuer added this to the 2.4.0 milestone Jan 24, 2024
res/skins/Shade/style.qss Outdated Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Jan 24, 2024

Here's the hotcue button fix d4ffc38
WHotcueButton needs pixmaps for 3 states, that's it.

Please fixup/squash my suggestion above, then pick the fix. Feel free to merge yourself!

@daschuer daschuer merged commit ac88079 into mixxxdj:2.4 Jan 24, 2024
13 checks passed
@daschuer
Copy link
Member Author

Thank you, for help! Works perfectly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants