Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOsVersion: Import Foundation instead of Cocoa #12646

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Jan 26, 2024

Cocoa/AppKit is unavailable on iOS and since we only use Foundation APIs here anyway, we can just import it directly.

@fwcd fwcd added the macos label Jan 26, 2024
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still green, Thank you. LGTM

@daschuer daschuer merged commit 1b98708 into mixxxdj:2.4 Jan 26, 2024
13 checks passed
@fwcd fwcd deleted the macos-version-foundation branch January 27, 2024 03:50
@fwcd fwcd mentioned this pull request Jan 27, 2024
54 tasks
@fwcd fwcd added the ios label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants