Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLWaveformRenderer: Move OpenGL 2.1 include into cond-compile #12664

Merged
merged 1 commit into from
Jan 27, 2024
Merged

GLWaveformRenderer: Move OpenGL 2.1 include into cond-compile #12664

merged 1 commit into from
Jan 27, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Jan 27, 2024

A minor fix that surfaced while compiling for iOS.

@fwcd fwcd mentioned this pull request Jan 27, 2024
Open
54 tasks
daschuer
daschuer approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@JoergAtGithub JoergAtGithub merged commit 637ec31 into mixxxdj:2.4 Jan 27, 2024
14 checks passed
@fwcd fwcd added the ios label Jan 28, 2024
@fwcd fwcd deleted the qopengl-cond-compile branch February 2, 2024 23:16
@djantti djantti mentioned this pull request Feb 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
ios waveform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fwcd @daschuer @JoergAtGithub