update beatloop_X_enabled COs when using loop_in/out

[Be-ing]

and quantize is enabled. This is helpful for controllers that have a grid of pads mapped to fixed beatloop sizes. This can be tested on skins that have not been updated to use the new looping UI introduced by #1187.

Fixing Launchpad Bug 1159245

[daschuer]

Thank you, this works good now.

[daschuer]

I have just noticed a different issue. We have changed that the loop out changes to the next beat when it is outside the loop. This works good if you are outside the loop and want to enlarge it.
It feels odd, if you want to make the loop smaller.
I think we should revert this behavior for the later case.

What do you think?

[Be-ing]

I think we should keep the current behavior. If holding loop_out with quantize snapped to the previous beat when seeking backward, that would re-introduce the weird situation with the loop enabled but the play position outside the loop boundaries. Also, snapping back at the half way point between beats might be unexpected.

[daschuer]

If holding loop_out with quantize snapped to the previous beat, that would re-introduce the weird situation with the loop enabled but the play position outside the loop boundaries.

That is out of question. I have just stumbled about the situation to halve a two beat loops.
If you want to hit the beat and you miss it by some samples, nothing happens, because it snaps to the next beat. A solution would be to to distinguish these situation.

An other wired behavior is if you are behind a disabled loop, pressing Loop out set the loop out point to the nearest beat, in this case left and enables the loop. If you press the loop out button again, it snapas to the next beat right.

[Be-ing]

I have just stumbled about the situation to halve a two beat loops. If you want to hit the beat and you miss it by some samples, nothing happens, because it snaps to the next beat. A solution would be to to distinguish these situation.

I do not understand what the issue is or what situations you're suggesting could be distinguished. You can also press the down button on the beatloop_size spinbox or loop_halve in that situation.

An other wired behavior is if you are behind a disabled loop, pressing Loop out set the loop out point to the nearest beat, in this case left and enables the loop. If you press the loop out button again, it snapas to the next beat right.

Yes, this is how it has to be to prevent the play position from going outside the loop when resizing a loop. It is an exception to how quantize works in other situations (snapping to nearest beat).

[daschuer]

I think there must be a way to improve this situation without a regression for holding down loop out. I will give it a try. Am 30.05.2017 11:20 nachm. schrieb "Be" <notifications@github.com>:

…

I have just stumbled about the situation to halve a two beat loops. If you want to hit the beat and you miss it by some samples, nothing happens, because it snaps to the next beat. A solution would be to to distinguish these situation. I do not understand what the issue is or what situations you're suggesting could be distinguished. You can also press the down button on the beatloop_size spinbox or loop_halve in that situation. An other wired behavior is if you are behind a disabled loop, pressing Loop out set the loop out point to the nearest beat, in this case left and enables the loop. If you press the loop out button again, it snapas to the next beat right. Yes, this is how it has to be to prevent the play position from going outside the loop when resizing a loop. It is an exception to how quantize works in other situations (snapping to nearest beat). — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1267 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABsfIr6hNYxLpdR9cO2UAz8Tt4J2F5QZks5r_IgIgaJpZM4NnNXC> .