Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 2.4 to main #12685

Closed
wants to merge 142 commits into from
Closed

Merge 2.4 to main #12685

wants to merge 142 commits into from

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Jan 29, 2024

This merges 2.4 to main. Leaves all of the translation files untouched (I hope that's how this is done?)

ronso0 and others added 30 commits March 19, 2023 22:08
This prevents a sudden pitch change in the leader deck.
…e postPorcess()

This fixes the issue of changing pitch in two clones playing in sync
This is required for a reliable sync feature with changing tempo tracks. All other scalers have already double precision.
Co-authored-by: Owen Williams <owen-github@ywwg.com>
Co-authored-by: Uwe Klotz <uwe.klotz@gmail.com>
…gl-no-precision

fix(waveforms): add missing precision specifier to repetions uniform of patternshader
…ware/mixxxdj/mixxx2-4/. Compile QM files out of TS files that are used by the localized app
CMakeLists.txt Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, this slipped in by accident.
I'll remove it and merge to main after this has been merged.

CMakeLists.txt Outdated Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Jan 30, 2024

The effects, skins and other recent changes I was involved look good.
@daschuer did you check the cmake changes?

@fwcd
Copy link
Member Author

fwcd commented Jan 30, 2024

Did another merge (and reran tools/update_metainfo.py), to get #12687 included.

@ronso0
Copy link
Member

ronso0 commented Jan 30, 2024

I suggest to keep this as is, not extend it further so it remains somewhat reviewable and gets merged soonish.
Otoh, I haven't followed the cmake/iOS changes so I don't know what can go wrong.

I already used this to rebase my personal branch, but that doesn't mean much I guess since I only build on Linux.

@fwcd
Copy link
Member Author

fwcd commented Jan 30, 2024

There are not really a lot of CMake changes (#12661, #12662, #12673 OTOH, but all of them have already been reviewed). Sadly, GitHub doesn't offer a good way to visualize just the conflict resolutions (i.e. what has changed apart from the "automatic" merge, which, in this case, is mostly just merging together a few adjacent methods in the star rating widgets, if I remember right)

@fwcd
Copy link
Member Author

fwcd commented Jan 30, 2024

The more "drastic" CMake changes for iOS support are coming in #12672 and will target main once this is merged (since I've already resolved conflicts locally)

@ronso0
Copy link
Member

ronso0 commented Jan 30, 2024

Well then, CI passes and if you're confident nothing broke, we can merge. Nevertheless I'd appreciate a second pair of eyes here.

@fwcd
Copy link
Member Author

fwcd commented Jan 30, 2024

Did another quick local smoke-test, there are at least no obvious regressions. I agree that the large merge diffs are hard to review, though I can't really speak on most of the changes apart from what I've been involved in.

@daschuer
Copy link
Member

daschuer commented Feb 1, 2024

I have adjusted the CMakeLists.txt at one point and updated with the latest 2.4 branch here:
14c2270

Thank you for the work.

@daschuer daschuer closed this Feb 1, 2024
@fwcd fwcd deleted the merge-2.4 branch February 2, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants