Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlists: enforce update of playlist labels #12866

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Feb 24, 2024

For some reason (I failed to find) the sidebar labels aren't updated anymore in main (with Qt6) when adding a track to a playlist.

Closes #12761

@ronso0 ronso0 marked this pull request as ready for review February 24, 2024 01:03
@ronso0
Copy link
Member Author

ronso0 commented Feb 24, 2024

Still it would be good to know the root cause since @m0dB says this was working fine when they worked on #12020 (based on main). I'll try to find a working ref in main (some day in Sep '23) and bisect (assuming this is a Mixxx issue because I'm pretty sure my Qt6 source didn't change).

@ronso0
Copy link
Member Author

ronso0 commented Feb 24, 2024

I'll try to find a working ref in main (some day in Sep '23) and bisect (assuming this is a Mixxx issue because I'm pretty sure my Qt6 source didn't change).

I checked out a ref where 2.4 was merged to main in August but that also had the issue.
I case someone wants to dig deeper, go ahead. But for now I think this fix is okay, maybe even more sustainable because of the explicit repaint.

@m0dB m0dB merged commit 2f10a52 into mixxxdj:main Feb 24, 2024
13 checks passed
@m0dB
Copy link
Contributor

m0dB commented Feb 24, 2024

I agree. The solution is clear and clean and I don't think it's worth it to invest more time investigating this. Thanks for the quick action, @ronso0 !

@ronso0 ronso0 deleted the playlist-counter-fix branch February 25, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

playlist - count and totaltime not updated when adding a song
2 participants