Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MixxxApplication: Use QWasmIntegrationPlugin when targeting WebAssembly #12915

Merged
merged 2 commits into from
Mar 4, 2024
Merged

MixxxApplication: Use QWasmIntegrationPlugin when targeting WebAssembly #12915

merged 2 commits into from
Mar 4, 2024

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Mar 4, 2024

This imports the WASM integration plugin when Q_OS_WASM is defined and compiles out the QOffscreenIntegrationPlugin and QMinimalIntegrationPlugin, which are unavailable when targeting WASM.

@fwcd fwcd added the wasm label Mar 4, 2024
@fwcd fwcd mentioned this pull request Mar 4, 2024
Open
13 tasks
daschuer
daschuer approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit 1c86a47 into mixxxdj:main Mar 4, 2024
13 checks passed
@fwcd fwcd deleted the qwasmintegrationplugin branch March 4, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fwcd @daschuer