CMakeLists: Enable asyncify when targeting WASM #12921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the QDialog::exec issue
13 tasks
fwcd
force-pushed
the
emscripten-asyncify
branch
from
1bb0b37
to
38425dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes calls that yield to the event loop when targeting WebAssembly (e.g.
QDialog::execwould previously crash), as per https://doc.qt.io/qt-6/wasm.html#asyncify.It does add some overhead unfortunately (the WASM binary went from 256M -> 304M and linking became considerably slower), even with the recommended optimizations (
-Os), but better to have something that runs than crashes.