Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists: Add WASM_ASSERTIONS option #12931

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Mar 7, 2024

This option will add additional checks, including stack overflow protection, which are disabled by default when building with optimizations (which we almost always do).

For more details, see https://emscripten.org/docs/porting/Debugging.html#compiler-settings

@fwcd fwcd added the wasm label Mar 7, 2024
@github-actions github-actions bot added the build label Mar 7, 2024
@fwcd fwcd marked this pull request as draft March 7, 2024 04:10
@fwcd
Copy link
Member Author

fwcd commented Mar 7, 2024

Hm, with assertions enabled we unfortunately get a lot of errors of the form

Cannot have multiple async operations in flight at once

Sadly, it is pretty hard to debug where these calls are coming from, i.e. whether it's something in Qt or in Mixxx, since we do not get a stack trace... This results in Mixxx not being able to launch at all.

Marking this as a draft for now.

@fwcd
Copy link
Member Author

fwcd commented Mar 8, 2024

We'll disable this option for now since it prevents Mixxx from launching currently (see this post for details, which is likely related to emscripten-core/emscripten#18412 and QTBUG-102827), but may be valuable for debugging in the future.

Marking as ready-for-review since it should be safe to merge (it doesn't change anything about the default config).

@fwcd fwcd marked this pull request as ready for review March 8, 2024 17:52
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit 3c1a619 into mixxxdj:main Mar 9, 2024
13 checks passed
@fwcd fwcd deleted the wasm-assertions branch March 9, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants