(fix) Library: allow adding new dirs while we have missing watched dir(s) #12937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
commented
Mar 9, 2024
| // Worst that can happen is that we have orphan tracks in the database that | ||
| // would be moved to missing after the rescan (which is required anyway after | ||
| // having added a new dir). | ||
| for (auto&& oldDir : loadAllDirectories(true)) { |
There was a problem hiding this comment.
Alternatively, use the current implemantation but don't return if the old dir is missing. Instead, do the QString equivalent of mixxx::FileInfo::isRootSubCanonicalLocation(new, old) in that case.
This requires refactirng here, i.e. use DirectoryDAO::getRootDirStrings() added in #12878 and construct the mixxx::FileInfo here.
daschuer
requested changes
Apr 14, 2024
src/library/dao/directorydao.cpp
Outdated
| << "does not exist or is inaccessible"; | ||
| return AddResult::InvalidOrMissingDirectory; | ||
| } | ||
| // Ignore invalid or missing directories in order to aloow adding new dirs |
There was a problem hiding this comment.
Suggested change
| // Ignore invalid or missing directories in order to aloow adding new dirs | |
| // Ignore invalid or missing directories in order to allow adding new dirs |
ronso0
force-pushed
the
lib-add-dir-while-missing-is-listed
branch
from
12c17e9
to
44177ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the original issue of #10481
I don't understand how the "inconsistencies" mentioned in the comment can be so serious that we have to prevent adding a new directory.
After a rescan, everything should be fine.