Support for bulk devices on Windows and Mac

[acolombier]

Allow bulk devices to be opened on Windows when using WinUSB and Mac.

[JoergAtGithub]

Some general suggestions. I've no USB Bulk device to test this.

[acolombier]

I took the initiative on expending the scope of this PR to also include Mac support as it seems it needs the same changes.

This was tested with S4 Mk3 screens

[JoergAtGithub]

You need also to enabled BULK support in our Windows build setups:

mixxx/tools/windows_buildenv.bat

Line 216 in 99406cb

CALL :AddCMakeVar2CMakeSettings_JSON "BULK" "BOOL" "False"

mixxx/.github/workflows/build.yml

Line 96 in 99406cb

-DBULK=OFF

[acolombier]

Just a heads up here - there seems to be reports of issues on Zulip about Mac and that feature. Let's hold on merging till we have further details and potentially fix the usecase first.

I did some testing on MacOS M1 (Sonoma I believe) and it worked but there might be edge case other arch/OS version

[JoergAtGithub]

I wonder what the kernel driver is, that needs to be detached, a generic one, that comes with the OS like WinUSB, or a Native Instruments driver for the S4 Mk3.
Maybe the detach of a Kernel driver is not necessary in case of Linux, just because this OS is not supported by Native Instruments?

[acolombier]

Maybe the detach of a Kernel driver is not necessary in case of Linux, just because this OS is not supported by Native Instruments?

Yes, I think your theory is correct.
Do you think this means we should potentially rework the Linux part to make it compatible with the fact that NI may (very unlikely) release NI kernel drivers too (and so require a similar libusb opening procedure?

[JoergAtGithub]

I'm not sure, but it would be good to test this without the NI driver package as well, to get a better understanding.
If the NI drivers are installed, we also need stop the service "NIHardwareService" on Windows, because it otherwise communicates via HID in parallel to Mixxx.

[acolombier]

It's worth to mention I had to change the kernel driver from the NI to WinUSB one, so I guess this usecase isn't possible, or is it? I'm not sure how we could allow both kernels (And services) to be toggled on demand, and since I don't have much experience on Windows (nor the setup, and the interest to be honest), it's hard for me to work on a robust comprehensive solution here.

[acolombier]

Could we consider merging this as-is as it is improving the overall bulk support on non-Linux platform (especially Mac, allowing bulk to work out of the box on MacOS 14).
Happy to create issues for the installer/further work to do on the Windows side to get that also working out of the box. In the meantime, I'd be happy to create a manual section to help installing WinUSB using some utility like Zadig

[JoergAtGithub]

The code is fine now, and I will merge it therefore!
But this functionality is not enough, that a normal Windows user can use USB Bulk devices as on Linux. This is because the WinUSB driver registration for the device must be done manually by an Administrator using a tool like Zadig.

[JoergAtGithub]

Thank you, for addressing this long pending limitation!