iTunes: Obtain FileAccess before accessing iTunes XML #13013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
commented
Mar 27, 2024
| @@ -65,6 +67,9 @@ ITunesImport ITunesXMLImporter::importLibrary() { | |||
| ITunesImport iTunesImport; | |||
| bool isMusicFolderLocatedAfterTracks = false; | |||
|
|
|||
| // In sandboxed builds we have to obtain an access token | |||
| auto access = mixxx::FileAccess(mixxx::FileInfo(m_xmlFilePath)); | |||
There was a problem hiding this comment.
Two notes on this:
- It would be nice if someone could verify that this still works properly on Windows/Linux (though I'd be very surprised if there were any issues given that the browse feature obtains access tokens in the same manner).
- We should probably also do this for the Serato/Traktor/... integrations
fwcd
changed the title
|
The error message looks confusing for this case. Can you adjust it as well? mixxx/src/library/itunes/itunesfeature.cpp Line 369 in 5ee50d7 |
fwcd
force-pushed
the
itunes-xml-access-token-2.4
branch
from
fdd3b08
to
92030cf
Compare
daschuer
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where opening an iTunes XML outside sandboxed directories would error in App Sandbox-enabled macOS builds, triggering the following dialog:
#13012 reveals that the error in this case is "Operation not permitted". Obtaining a
mixxx::FileAccessfixes the issue.