Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor FFmpeg soundsource to allow other soundsource to inherit it #13042

Conversation

acolombier
Copy link
Member

This is requirement for the STEM sound source

@acolombier acolombier force-pushed the feat/refactor-soundsourceffmpeg-for-inheritance branch from 26af185 to f8ef84f Compare April 3, 2024 21:11
@acolombier acolombier marked this pull request as draft April 4, 2024 16:56
@acolombier acolombier force-pushed the feat/refactor-soundsourceffmpeg-for-inheritance branch 2 times, most recently from c6c1408 to 897c298 Compare April 10, 2024 14:48
@acolombier acolombier marked this pull request as ready for review April 10, 2024 15:21
@acolombier acolombier force-pushed the feat/refactor-soundsourceffmpeg-for-inheritance branch from 897c298 to 87d9cef Compare April 11, 2024 16:29
src/sources/soundsourceffmpeg.cpp Outdated Show resolved Hide resolved
src/sources/soundsourceffmpeg.cpp Outdated Show resolved Hide resolved
src/sources/soundsourceffmpeg.h Outdated Show resolved Hide resolved
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit a2a8d5b into mixxxdj:main Apr 13, 2024
13 checks passed
@daschuer
Copy link
Member

Which one is the next?

@acolombier
Copy link
Member Author

That would be this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants