-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controller preferences: add :hwbtn: markup parser #13046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small code nitpick
f021bd2
to
35ed4cd
Compare
Thanks for looking into it @Holzhaus I think we're good with the solution. I expect it to look odd only if users have a monospace font configured e.g. with Qt6ct. |
oh, you already have fix ... |
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com> Co-authored-by: Jan Holthuis <jholthuis@mixxx.org>
35ed4cd
to
81a4188
Compare
No, just some minor improvement unfortunately 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in terms of code. Can't comment much on the formatting because I don't know HTML&CSS well enough.
LGTM! Thank you! |
Thanks everyone for the quick response! |
Sorry I didn't have time test this - thanks for looking into this @ronso0 ! |
Allows using :hwbtn:
LABEL
in xml and moves the styling to c++It's just bold now (dropped the
tt
monospace font tag).The only way I figured to get horizontal padding was to wrap the label in
Padding is not applied with
padding: 2px;
alone. Might be one of those qss quirks where we need to set an unrelated property, though withspan
neitherdisplay: inline-block;
norbox-sizing: border-box;
orborder
work@acolombier Mind taking a look?