Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 13060 loop gradient #13061

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Conversation

m0dB
Copy link
Contributor

@m0dB m0dB commented Apr 6, 2024

Fixes #13060

Before
Screenshot 2024-04-06 at 14 24 30

After
Screenshot 2024-04-06 at 14 54 06

…he hotcue marker texture) and rounding of play position marker
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I can confirm the issue is fixed.
I have not understand how to be honest ..

@daschuer daschuer merged commit faaef0a into mixxxdj:main Apr 7, 2024
13 checks passed
@daschuer
Copy link
Member

daschuer commented Apr 7, 2024

Oh, this needs also to go to 2.4. I will cherry pick it manually.

@m0dB
Copy link
Contributor Author

m0dB commented Apr 8, 2024

LGTM and I can confirm the issue is fixed. I have not understand how to be honest ..

The textures for the markers are drawn centered around the position in the waveform (This is not ideal, as this means the left side of e.g. a hot cue marker image is just transparency. It doesn't really matter for a signal digit hot cue, but it becomes a bit ridiculous with longer labels). The bug was that I used the x position of that texture also for the gradient, instead of the center position.

(The implementation with the centered image with transparency is carried over from the legacy implementation, I might improve this in a separate PR)

@m0dB
Copy link
Contributor Author

m0dB commented Apr 8, 2024

Oh, this needs also to go to 2.4. I will cherry pick it manually.

Oh, my bad! It was my intention to fix this on 2.4 but somehow I did it on main. Thanks for taking care of this!

@m0dB m0dB added this to the 2.4.1 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gradient for loop region not drawn at correct position
2 participants