Playlists: move tracks with Alt + Up/Down/PageUp/PageDown/Home/End

[ronso0]

Finally. Fixes #10826
This was rather easy only due the new Cut, Copy & Paste feature #12020. Thanks @m0dB !!
edit: Redone entirely by using the mechanics of table-internal drag'n'drop.

Also fixes an issue that dropping tracks at the bottom of a playlist wouldn't select the dropped tracks nor give a current index for navigation.

Also includes a small fix for pasteTracks() (same: current index for navi)

Applicable only in (unlocked) playlists.
(sort by # otherwise it's rather unpredictable)

• continuous selections are moved right away
• non-continuous selections are first consolidated at first/last row, then moved on next keypress may not be desired
• non-continuous selections can be consolidated at the top/bottom with Up/PageUp and Down/PageDown respectively
• wrap-around is suppressed to avoid undesirable overshoot with longpress (keyrepeat)

[ronso0]

FWIW I think the event->source() == this part of WTrackTableView::dropEvent() can be replaced with cut/paste.
@m0dB wdyt?

[ronso0]

Works, but draft again because I'll look into redoing moveTrack() -> moveTracks(QModelIndexList indices, int insertPos), moving all tracks at once.

edit I also briefly tried to (ab)use the dnd mechanics, i.e. construct a QDragMoveEvent but that's cumbersome and actually discouraged.

edit2
...but I'll check if a wrapper could work, i.e. a function that can be called by dragDropEvent() and moveTracks()

[nlw0]

That's great, I've tried out and it seems to work. I noticed that 'del' seems to have stopped working for me, though. Could it be related to this patch?

What would be a good way to implement library commands for this now, using emitKeyEvent?

[ronso0]

...but I'll check if a wrapper could work, i.e. a function that can be called by dragDropEvent() and moveTracks()

Yup, that works!
Will pick that to get around the (presumably) costly cut/paste ops

[ronso0]

...but I'll check if a wrapper could work, i.e. a function that can be called by dragDropEvent() and moveTracks()

Yup, that works! Will pick that to get around the (presumably) costly cut/paste ops

Done. Works like a charm, espcially consolidating non-continuous selections.

[ronso0]

And it avoids running into bug #13100 (or limitation once that is fixed) with tracks whose files are currently missing.

[ronso0]

In case someone experiences issues, I can make a debu commit from the trace output I have in my stash.

[daschuer]

Some finding. A manual test is pending.

[daschuer]

Works like a charm. You may rebase it now. Thank you.

[ronso0]

Yeij, thanks for testing!

[daschuer]

All green. Thank you.