Playlists: improve table update after deleting (purging) track files #13127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 18, 2024
ronso0
changed the title
daschuer
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13111 which I can actually only reproduce with main (couldn't find the change causing it).
But it doesn't hurt to get rid of the double select and have the now separate PlaylistDAO signals for
a) updating the sidebar and
b) reloading the current tracks in 2.4
Also enables Delete Track Files in playlists #13112
Though, no matter if main or 2.4, this feels like a bandaid anyway. PlaylistDAO looks unnecessarily complex, a better solution would probably be PlaylistStorage / PlaylistSummary (Crate equivalent) like proposed by @ninomp in #4846