Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Controller IO table: fix display text for Action/control delegate #13188

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Apr 30, 2024

The Action column displayed only "No control chosen".

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. LGTM. Thank you

@Swiftb0y Swiftb0y merged commit e09ed6a into mixxxdj:main Apr 30, 2024
13 checks passed
@ronso0 ronso0 deleted the pref-controller-io-action-text branch April 30, 2024 19:16
@ronso0
Copy link
Member Author

ronso0 commented May 1, 2024

good catch.

well, this was like an hour of debugging to understand that the current implmentation converted the control to QString (control description), which is actually what we want displayText() to return... but that couldn't handle it and returned "No control ..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants