Track/BPM: add bpmlock control
#13199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaces recently introduced `bpm_toggle_lock`, allows to bind GUI controls for toggle and feedback
|
I think I / we missed the opportunity to make full use of this new control in #13041, so in order to not have to break mappings later on I highly recommend to add this to 2.5-beta. |
daschuer
approved these changes
May 3, 2024
|
Thanks for the quick review! Nite to myself: |
|
I forgot to change the ControlPickerMenu, too. |
|
@FrankwaP I hope you noticed this fixup? |
|
@ronso0 Thank you for the ping as I might have missed this update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces recently introduced
bpm_toggle_lockwithbpmlock.Benefit is that we can now bind GUI controls also for feedback, e.g. have a BPM lock toggle and block/disable beatgrid controls if BPM are locked.
The pushbutton only triggers the un/locking in Track, CO is updated by track signal.