Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track menu, Remove from disk: stop and eject all affected decks #13214

Merged
merged 1 commit into from
May 13, 2024
Merged

Track menu, Remove from disk: stop and eject all affected decks #13214

merged 1 commit into from
May 13, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented May 6, 2024 •
edited
Loading

also stop decks and eject tracks if Move to Trash is invoked for track(s) from the tracks view.

@github-actions github-actions bot added the ui label May 6, 2024
@ronso0 ronso0 changed the base branch from 2.4 to main May 6, 2024 20:48
@ronso0 ronso0 added this to the 2.5-beta milestone May 6, 2024
daschuer
daschuer approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 135d0bb into mixxxdj:main May 13, 2024
14 checks passed
@ronso0 ronso0 deleted the trackmenu-remove-from-disk-stop-eject-players branch May 13, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
2.5-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@ronso0 @daschuer