New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waveforms: don't elide hotcue labels #13219

Merged

daschuer merged 1 commit into mixxxdj:main from ronso0:waveform-hotcue-label-noelide

May 8, 2024

Member

ronso0 commented May 7, 2024

fixes #10722

As explained in #10722, there is no reason to truncate the labels:

later marks would overlap the longer, previous marks
as soon as hotcues are out of sight, their labels are hidden

Is there some aspect I overlooked?


          Waveforms: don't elide hotcue labels

c82afa3

github-actions bot added the waveform label

daschuer approved these changes

View reviewed changes

Member

daschuer left a comment

LGTM

daschuer merged commit fc96155 into mixxxdj:main

13 checks passed

ronso0 deleted the waveform-hotcue-label-noelide branch

May 8, 2024 21:57

Abdull mentioned this pull request

Hotcue marker text is cut off in waveform summary (but not in waveform overview) #10722

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels