Numark PartyMix: fix EQ (script binding) display name #13255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group [EqualizerRack1_[ChannelN]_Effect1] will not be translated in the mapping IO GUI, and it's not required since it's already set via components. Simply use [ChannelN] to get the translated string 'Deck N' in the GUI
Swiftb0y
approved these changes
May 22, 2024
|
It's not about the translation itself but about the sorting. With the previous group |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while testing the mapping IO table with a built-in mapping.
Group
[EqualizerRack1_[ChannelN]_Effect1]will not be translated in the mapping IO GUI, and it's not required since it's already set via components. Simply use[ChannelN]to get the translated string 'Deck N' in the GUI.