Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Handle not supported files when dragging to waveforms and spinnies" #13271

Merged
merged 1 commit into from
May 23, 2024

Conversation

ywwg
Copy link
Member

@ywwg ywwg commented May 23, 2024

Reverts #13208

Tested manually, this fixes waveform drag breakage

@github-actions github-actions bot added the ui label May 23, 2024
@ywwg ywwg marked this pull request as ready for review May 23, 2024 15:19
@acolombier
Copy link
Member

Looks like merging this would un-fix #13206.
Looking at the code change, the bug appears to be fairly trivial to fix. Shall we consider fixing it instead of reverting entirely?

@ywwg ywwg requested review from daschuer and m0dB May 23, 2024 15:23
@ywwg
Copy link
Member Author

ywwg commented May 23, 2024

My preference when there is a breakage is to revert first and then work on a corrected fix, rather than try to "fix forward"

(example reasoning: https://www.linkedin.com/pulse/service-recovery-rolling-back-vs-forward-fixing-mohamed-el-geish)

@ywwg
Copy link
Member Author

ywwg commented May 23, 2024

too often, what seems to be a simple fix on top of a breakage ends up making the situation worse, and then you have to fix on top of that.... unless the cost of rolling back is huge, it's best to do that first.

@daschuer
Copy link
Member

@acolombier If you have a fix under your thumb, we may test it and decide. Both are easy to test IMHO.

@acolombier
Copy link
Member

I don't yet, but might be able to get one together later today. Happy with the revert so this isn't a blocker

@ywwg
Copy link
Member Author

ywwg commented May 23, 2024

can someone approve so we can fix the 2.4 branch then?

@ywwg ywwg merged commit 7069f69 into 2.4 May 23, 2024
23 checks passed
@Swiftb0y Swiftb0y deleted the revert-13208-gh13206 branch May 23, 2024 17:12
@Swiftb0y
Copy link
Member

fyi @ywwg it seems like you're pushing your personal branches upstream. Check your get config please.

@daschuer
Copy link
Member

The fix is here: #13275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants