Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show 'hide menubar?' dialog on Linux only when the menubar will be in the window #13301

Merged
merged 1 commit into from
May 30, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented May 29, 2024

i.e. only if global menu is not supported or if it is and we're when going fullscreen

fixes a regression introduced when fixing conflicts before merging #11526

… the window

i.e. only if global menu is not supported or if it is and we're when going fullscreen
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it is fixed with Chinamon and Unity on Ubuntu Focal.
Thank you.

@daschuer daschuer merged commit 8022982 into mixxxdj:2.5 May 30, 2024
13 checks passed
@ronso0 ronso0 deleted the menubar-fullscreen-toggle branch May 30, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants