Fix Sony SixxAxis controller not working #13319
Conversation
|
Unfortunately the Ci is failing: |
|
My thinking was to first get the original mapping back to functional with minimal changes (achieved through this PR) and create an additional mapping without the bugs of this mapping in a separate PR. If you believe these two steps should be combined into a single PR and this dysfunctional mapping should be wholly overwritten, I will keep this PR as a draft and add the revised mapping. |
There was a problem hiding this comment.
My thinking was to first get the original mapping back to functional with minimal changes (achieved through this PR) and create an additional mapping without the bugs of this mapping in a separate PR. If you believe these two steps should be combined into a single PR and this dysfunctional mapping should be wholly overwritten, I will keep this PR as a draft and add the revised mapping.
Please keep them separate. In order to not break our CI pipeline, we need ensure that all the checks pass here (which in this case amounts to applying my suggestion below). Please do that and rebase the commits on the 2.4 branch so people receive the updated mapping faster. Thank you.
There was a problem hiding this comment.
LGTM. Thanks for improving this! Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.
|
@Swiftb0y all done! |
|
Thank you very much. Looking forward to your follow up PR. |
Minor fix in mapping file of sony sixxaxis controller. A wrong
HIDPacketinitialization was setting the length to 0, thus packets couldn't be parsed.