(opti/cleanup) make use of WLibrary::getCurrentTrackTableView() #13335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2024
ronso0
force-pushed
the
library-getCurrentTrackTableView
branch
from
3d10f99
to
88c1980
Compare
cr7pt0gr4ph7
suggested changes
Jun 7, 2024
src/widget/wlibrary.cpp
Outdated
Comment on lines
109
to
110
| // This view is no tracks view, but maybe a special library view with a | ||
| // controls row and a track view (DlgAutoDJ, DlgRecording)? |
There was a problem hiding this comment.
Were already cleaning up this comment, so it would make sense to fix all spelling & grammatical errors:
// This view is not a tracks view, but possibly a special library view
// with a controls row and a tracks view (DlgAutoDJ, DlgRecording,
// DlgHidden, DlgMissing, ...).
There was a problem hiding this comment.
Thanks!
FYI if you mark lines in the file diff tab you can click the +- button for change suggestions. This makes it easier to spot the difference.
|
Looks good (apart from the comment spelling nitpick). |
and move WLibraryTableView::moveSelection to WTracktableView (simplifies LibraryControl etc.)
ronso0
force-pushed
the
library-getCurrentTrackTableView
branch
from
88c1980
to
55fa9af
Compare
|
LGTM! Thank you! |
cr7pt0gr4ph7
added a commit
to cr7pt0gr4ph7/mixxx
that referenced
this pull request
Jun 22, 2024
…tem-shortcut Adapts the code to the changes introduced by mixxxdj#13335 in commit 55fa9af.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and move WLibraryTableView::moveSelection to WTracktableView (simplifies LibraryControl etc.)
This allows to call many methods directly from LibraryControl and remove virtuals from libraryview.h and the respective overrides from various library features.