Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize control code #13354

Merged
merged 13 commits into from
Aug 18, 2024
Merged

Optimize control code #13354

merged 13 commits into from
Aug 18, 2024

Commits on Jun 28, 2024

  1. Reserve memory m_controls before filling it in loop

    @JoergAtGithub
    JoergAtGithub committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d1cee54 View commit details
    Browse the repository at this point in the history

  2. Moved duplicated code in new private function setBehavior

    @JoergAtGithub
    JoergAtGithub committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    ea4fb6a View commit details
    Browse the repository at this point in the history

  3. Memory alignment of ControlDoublePrivate to reduce size from 464 byte… 

    … to 448 byte

First fields fit in 128 byte SSE register now
    @JoergAtGithub
    JoergAtGithub committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    829ae91 View commit details
    Browse the repository at this point in the history

  4. Add comment about memory alignment 

    Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>
    @JoergAtGithub @daschuer
    JoergAtGithub and daschuer committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    a1b5c25 View commit details
    Browse the repository at this point in the history

  5. Renamed setBehavior to updateBehavior and added a real setBehavior fu… 

    …nction and made use of it where applicable.

Unified the two ButtonMode enums to a common enum class.
    @JoergAtGithub
    JoergAtGithub committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    69e1231 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Merge remote-tracking branch 'upstream/main' into optimize_control_code

    @JoergAtGithub
    JoergAtGithub committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    891bedb View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Merge remote-tracking branch 'upstream/main' into optimize_control_code

    @JoergAtGithub
    JoergAtGithub committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    0fb3ed0 View commit details
    Browse the repository at this point in the history

  2. Removed unecessary keyword enum

    @JoergAtGithub
    JoergAtGithub committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    e51a92e View commit details
    Browse the repository at this point in the history

  3. Removed redundant cast

    @JoergAtGithub
    JoergAtGithub committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    45ef076 View commit details
    Browse the repository at this point in the history

  4. Renamed enum entries accrding cpp core guidelines

    @JoergAtGithub
    JoergAtGithub committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    dec4a9d View commit details
    Browse the repository at this point in the history

  5. Updated buttonModeToString to use QStringLiteral and added DEBUG_ASSE… 

    …RT for unexpected ControlButtonMode values.

Replaced header guard with #pragma once. Removed author and GPL
comment blocks.
    @JoergAtGithub
    JoergAtGithub committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    6728c91 View commit details
    Browse the repository at this point in the history

  6. Moved handling of default path out of the switch statement

    @JoergAtGithub
    JoergAtGithub committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    6c49909 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Use namespace for control button mode

    @JoergAtGithub
    JoergAtGithub committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    abc798a View commit details
    Browse the repository at this point in the history