fix high details waveforms wrapping around after visual index 65K #13491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm, this crashes with large waveforms, needs more debugging |
ywwg
force-pushed
the
ywwg/fix-high-details
branch
from
bfedab0
to
08babad
Compare
ywwg
force-pushed
the
ywwg/fix-high-details
branch
from
08babad
to
017c7fd
Compare
|
(works now) |
|
I don't think I'm the right person for this. I have not been involved in the stems code at all. wdyt @acolombier of this fix? |
|
yeah I wasn't able to tag @acolombier as a reviewer |
|
I just wanted to report this strange bug that high detail waveform wrap around at 2:28. My first thought was that my analyzed waveforms got corrupted or something 😄 Glad to know this is being handled |
acolombier
approved these changes
Jul 25, 2024
|
@acolombier Thanks for your review! LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13472