Fix sampler sync functionality for Mixxx skins #13820
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR! |
|
Since this is a fix it should target the stable branch 2.4 If you need help with git just let us know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with the sampler sync functionality across several Mixxx skins, updating the sync control to improve usability and ensure consistency in behavior.
Changes Made:
Updated XML Configuration Files for Skins:
Replaced beatsync_beatsync_tempo with sync_enabled in the following XML files to align with the updated sync functionality:
Deere: res/skins/Deere/sampler_controls_row.xml (Line 88)
Shade: res/skins/Shade/sampler.xml (Line 301)
LateNight: res/skins/LateNight/samplers/sampler.xml (Line 370)
Tango: res/skins/Tango/mic_aux_sampler/sampler.xml (Lines 128 and 340)
Updated Tooltip and Connection Attributes:
Modified the TooltipId and left_connection_control attributes as required to use sync_enabled for improved control and readability.
Testing:
Verified each skin to ensure that pressing the sync button behaves as expected.
Held the sync button to confirm that the "lock sync" feature engages as described.
No issues or regressions observed after these changes.
Additional Notes:
This PR focuses solely on improving sync consistency across the mentioned skins and should not affect other skin functionality.
Please review and test the sync button behavior, especially for the lock sync feature, to confirm these changes work across various setups.