Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive and thread-safe track analysis (ad-hoc + batch) #1413

Closed
wants to merge 146 commits into from
Closed

Responsive and thread-safe track analysis (ad-hoc + batch) #1413

wants to merge 146 commits into from

Commits on Dec 24, 2017

  1. Fix potential race condition in AnalyzerQueue... 

    ...that might prematurely abort a batch analysis. The blocking operation
must be enclosed in a loop.
    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    cfbcfb7 View commit details
    Browse the repository at this point in the history

  2. More minor fixes and verbose logging

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    6b2b0c7 View commit details
    Browse the repository at this point in the history

  3. Use atomic primitives for safe cross-thread access

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    01b0123 View commit details
    Browse the repository at this point in the history

  4. Fix condition for prioritizing tracks queued for analysis 

    ...after introducing a bug during refactoring.
    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    c7299af View commit details
    Browse the repository at this point in the history

  5. Replace flags with enumeration to illustrate (and fix?) the workflow

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    ef6f4ae View commit details
    Browse the repository at this point in the history

  6. Fix race condition when enqueuing multiple tracks for analysis

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    59ebd63 View commit details
    Browse the repository at this point in the history

  7. Add missing invocation of resume()

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    6e9a8af View commit details
    Browse the repository at this point in the history

  8. Define constants for progress updates and reduce frequency to 250 ms

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    15fd856 View commit details
    Browse the repository at this point in the history

  9. Ensure that the last track reference is dropped in the main thread

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    1ccc74b View commit details
    Browse the repository at this point in the history

  10. Lock-free propagation of progress updates from analyzer thread

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    6594879 View commit details
    Browse the repository at this point in the history

  11. Increase frequency of progress updates during analysis

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    8f9a5b5 View commit details
    Browse the repository at this point in the history

  12. Make the analysis progress updates smarter

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    1ee6767 View commit details
    Browse the repository at this point in the history

  13. Try to publish accumulated progress updates before suspending thread 

    Just in case that the analysis thread did not get the chance to
deliver the updates while analyzing tracks.
    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    a51a020 View commit details
    Browse the repository at this point in the history

  14. Improve some comments

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    499d2ba View commit details
    Browse the repository at this point in the history

  15. Define and use public constants for analyzer progress

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    21dad23 View commit details
    Browse the repository at this point in the history

  16. Pre-filter tracks before analysis 

    Also fixed a wrong logic shortcut when determining if tracks need to be
analyzed.
    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    003ed50 View commit details
    Browse the repository at this point in the history

  17. Fix and optimize enqueuing of tracks for analysis

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    918f561 View commit details
    Browse the repository at this point in the history

  18. Add some housekeeping and consistency checks

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    4944416 View commit details
    Browse the repository at this point in the history

  19. Fix various issues in AnalyzerQueue by rewriting major parts

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    f00a3ae View commit details
    Browse the repository at this point in the history

  20. Do not prioritize any tracks within a single analyzer queue

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    27945e5 View commit details
    Browse the repository at this point in the history

  21. Separate and reduce thread-private members

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    82f4012 View commit details
    Browse the repository at this point in the history

  22. Rename/reorder/remove some members

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    15b9bbd View commit details
    Browse the repository at this point in the history

  23. Separate AnalyzerThread from AnalyzerQueue

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    0e8a98e View commit details
    Browse the repository at this point in the history

  24. Defer loading of track objects until analysis actually starts

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    3b59792 View commit details
    Browse the repository at this point in the history

  25. Fix serious race condition that may cause a segfault

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    6cdb275 View commit details
    Browse the repository at this point in the history

  26. Improve initialization of analysis view

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    f7beba6 View commit details
    Browse the repository at this point in the history

  27. Add a placeholder for unknown analysis progress

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    c1173b8 View commit details
    Browse the repository at this point in the history

  28. Explicitly load() atomic values

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    9281167 View commit details
    Browse the repository at this point in the history

  29. Fix communication between AnalyzerThread and AnalyzerQueue

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    506de02 View commit details
    Browse the repository at this point in the history

  30. Emit a 3rd signal in AnalyzerThread and AnalyzerQueue

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    652bda7 View commit details
    Browse the repository at this point in the history

  31. (Re-)establish a consistent naming for "analyzer progress"

    @uklotzde
    uklotzde committed Dec 24, 2017
    Configuration menu
    Copy the full SHA
    4899f2d View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2017

  1. Use std::deque instead of QQueue

    @uklotzde
    uklotzde committed Dec 25, 2017
    Configuration menu
    Copy the full SHA
    533a574 View commit details
    Browse the repository at this point in the history

  2. Use C++ STL threading 

    ...using a simple non-recurisve mutex
    @uklotzde
    uklotzde committed Dec 25, 2017
    Configuration menu
    Copy the full SHA
    9e71e8e View commit details
    Browse the repository at this point in the history

  3. Use type-safe C++ <chrono> types

    @uklotzde
    uklotzde committed Dec 25, 2017
    Configuration menu
    Copy the full SHA
    c076cc4 View commit details
    Browse the repository at this point in the history

  4. Prepare to use multiple worker threads for track analysis

    @uklotzde
    uklotzde committed Dec 25, 2017
    Configuration menu
    Copy the full SHA
    4829701 View commit details
    Browse the repository at this point in the history

  5. Make VampPluginLoader thread-safe

    @uklotzde
    uklotzde committed Dec 25, 2017
    Configuration menu
    Copy the full SHA
    8bac32b View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2017

  1. Only currently analyzed tracks should report valid progress

    @uklotzde
    uklotzde committed Dec 26, 2017
    Configuration menu
    Copy the full SHA
    dd54547 View commit details
    Browse the repository at this point in the history

  2. Add thread-safe unloading of Vamp plugins

    @uklotzde
    uklotzde committed Dec 26, 2017
    Configuration menu
    Copy the full SHA
    c42cd75 View commit details
    Browse the repository at this point in the history

  3. Multi-threaded AnalyzerQueue (currently disabled)

    @uklotzde
    uklotzde committed Dec 26, 2017
    Configuration menu
    Copy the full SHA
    aa51830 View commit details
    Browse the repository at this point in the history

  4. Rename and change signal parameters

    @uklotzde
    uklotzde committed Dec 26, 2017
    Configuration menu
    Copy the full SHA
    e0f8b8b View commit details
    Browse the repository at this point in the history

  5. Resolve race conditions between AnalyzerQueue and Analysisfeature

    @uklotzde
    uklotzde committed Dec 26, 2017
    Configuration menu
    Copy the full SHA
    4938d76 View commit details
    Browse the repository at this point in the history

  6. Enable multi-threaded adhoc and batch analysis

    @uklotzde
    uklotzde committed Dec 26, 2017
    Configuration menu
    Copy the full SHA
    97d3880 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2017

  1. Use ControlValueAtomic for lock-free data transfer

    @uklotzde
    uklotzde committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    31ec755 View commit details
    Browse the repository at this point in the history

  2. Undo changes in VampPluginLoader 

    ...the threading issues were caused by another bug somewhere else.
    @uklotzde
    uklotzde committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    5abd2d4 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2018

  1. Revert "Undo changes in VampPluginLoader" 

    The VampPluginLoader code is NOT thread-safe! But even in 2.0 we already
create Vamp plugins from multiple threads which might fail unpredictably!!

See also: http://vamp-plugins.org/forum/index.php?topic=206.0

This reverts commit 5abd2d4.
    @uklotzde
    uklotzde committed Jan 1, 2018
    Configuration menu
    Copy the full SHA
    12c6989 View commit details
    Browse the repository at this point in the history

  2. Fix debug assertion when stopping a batch analysis

    @uklotzde
    uklotzde committed Jan 1, 2018
    Configuration menu
    Copy the full SHA
    185b57b View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2018

  1. Address all minor review comments

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    f078fa3 View commit details
    Browse the repository at this point in the history

  2. Simplify analyzer progress calculations in waveform overview

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    34ad1dd View commit details
    Browse the repository at this point in the history

  3. Remove the need for AnalyzerMode enum

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    5453098 View commit details
    Browse the repository at this point in the history

  4. Remove analyzer progress from track object

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    9b31aa0 View commit details
    Browse the repository at this point in the history

  5. Delete obsolete special case handling

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    2273b09 View commit details
    Browse the repository at this point in the history

  6. Add some clarifying comments about analyzer threads

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    d85be80 View commit details
    Browse the repository at this point in the history

  7. Delete unnecessary member variable

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    d0548be View commit details
    Browse the repository at this point in the history

  8. Avoid blocking when destroying analyzer threads

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    eb9b55f View commit details
    Browse the repository at this point in the history

  9. Fix debug assertion when destroying PlayerManager

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    800541a View commit details
    Browse the repository at this point in the history

  10. Manage destruction of dynamically allocated analyzer queue objects

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    a22df4e View commit details
    Browse the repository at this point in the history

  11. Fix shutdown of analyzer worker threads

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    cc4b379 View commit details
    Browse the repository at this point in the history

  12. Encode analyzer progress as double instead of integer promille

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    557c260 View commit details
    Browse the repository at this point in the history

  13. Merge branch '2.1' into lp1737537

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    7451397 View commit details
    Browse the repository at this point in the history

  14. Use a debug assertion to check for the impossible

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    a1f3795 View commit details
    Browse the repository at this point in the history

  15. Don't use return value of assignment to avoid confusion

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    f597bfd View commit details
    Browse the repository at this point in the history

  16. Revert "Remove the need for AnalyzerMode enum" 

    This reverts commit 5453098.

# Conflicts:
#	src/analyzer/analyzerthread.cpp
#	src/analyzer/analyzerthread.h
    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    b03066f View commit details
    Browse the repository at this point in the history

  17. Rename query function to improve readability

    @uklotzde
    uklotzde committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    23a2e4b View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2018

  1. Linear progress display for single- and multi-threaded use cases

    @uklotzde
    uklotzde committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    2abdde4 View commit details
    Browse the repository at this point in the history

  2. Workaround for a debug assertion that might be triggered in rare cases

    @uklotzde
    uklotzde committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    2b35c69 View commit details
    Browse the repository at this point in the history

  3. Move slot from AnalyzerQueue to PlayerManager

    @uklotzde
    uklotzde committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    d9a4a6a View commit details
    Browse the repository at this point in the history

  4. Add pause/resume ability to the analyzer queue and worker threads

    @uklotzde
    uklotzde committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    b2d7c59 View commit details
    Browse the repository at this point in the history

  5. Suspend and resume batch analysis during ad-hoc analysis

    @uklotzde
    uklotzde committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    d6c2701 View commit details
    Browse the repository at this point in the history

  6. Explain decision to abandone analyzer queue after batch analysis comp… 

    …leted
    @uklotzde
    uklotzde committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    801fd7a View commit details
    Browse the repository at this point in the history

  7. Remove unused signal

    @uklotzde
    uklotzde committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    f73e179 View commit details
    Browse the repository at this point in the history

  8. Streamline pausing and stopping of analyzer threads

    @uklotzde
    uklotzde committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    d50b615 View commit details
    Browse the repository at this point in the history

  9. Fix memory management of analyzer threads

    @uklotzde
    uklotzde committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    a7c0d53 View commit details
    Browse the repository at this point in the history

  10. Restore BPM preferences after stopping batch analysis 

    Got lost during the refactoring.
    @uklotzde
    uklotzde committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    019bfbf View commit details
    Browse the repository at this point in the history

  11. Fix ugly and error prone bpm detection enforcement hack 

    The AnalyzerMode enumeration is still not very handy, but sufficient
until a future refactoring of the analyzer framework.
    @uklotzde
    uklotzde committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    777cc7d View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2018

  1. Minor renamings and more detailed documentation

    @uklotzde
    uklotzde committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    755d4d2 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2018

  1. Split reusable WorkerThread base class from AnalyzerThread

    @uklotzde
    uklotzde committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    2b9db6c View commit details
    Browse the repository at this point in the history

  2. Simplify analyzer thread loop

    @uklotzde
    uklotzde committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    bd584ce View commit details
    Browse the repository at this point in the history

  3. Reduce verbosity of WorkerThread

    @uklotzde
    uklotzde committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    d7067b8 View commit details
    Browse the repository at this point in the history

  4. Allow worker threads to get paused when idle 

    ...this is needed for the engine workers that need to fall asleep
as soon as no more work is ready for them.
    @uklotzde
    uklotzde committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    ca6df2a View commit details
    Browse the repository at this point in the history

  5. Add WorkerThreadScheduler = universal EngineWorkerScheduler 

    ...just to demonstrate the versatility of the new approach
    @uklotzde
    uklotzde committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    b079342 View commit details
    Browse the repository at this point in the history

  6. Explicitly call pause() for tracing

    @uklotzde
    uklotzde committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    4200787 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2018

  1. Improve logging for PlayerManager

    @uklotzde
    uklotzde committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    18b8fc5 View commit details
    Browse the repository at this point in the history

  2. Avoid dropping the last reference of track objects in worker threads!

    @uklotzde
    uklotzde committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    cc1a410 View commit details
    Browse the repository at this point in the history

  3. Various improvements to the worker thread framework for track analysis

    @uklotzde
    uklotzde committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    0e44f4c View commit details
    Browse the repository at this point in the history

  4. Reduce shared state between threads 

    ...to improve consistency of exchanged progress data and to reduce
potential side effects.
    @uklotzde
    uklotzde committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    a7b4de5 View commit details
    Browse the repository at this point in the history

  5. Visually improve analysis progress display

    @uklotzde
    uklotzde committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    0e3afe9 View commit details
    Browse the repository at this point in the history

  6. Start analyzer workers in suspended state

    @uklotzde
    uklotzde committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    6a29673 View commit details
    Browse the repository at this point in the history

  7. Rename functions/signals/slots (once again)

    @uklotzde
    uklotzde committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    8362a6a View commit details
    Browse the repository at this point in the history

  8. Renaming: AnalyzerQueue -> TrackAnalysisScheduler 

    ...the internal "queue" is just an implementation detail. The actual
purpose of this class is to schedule tracks for analysis and invoke
the analyzers concurrently in the background.
    @uklotzde
    uklotzde committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    973960b View commit details
    Browse the repository at this point in the history

  9. Add thread-safe wrappers for thread-unsafe fidlib functions

    @uklotzde
    uklotzde committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    508443e View commit details
    Browse the repository at this point in the history

  10. Simplify (and fix?) initialization of VampPluginLoader

    @uklotzde
    uklotzde committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    4c28f4a View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2018

  1. Synchonize Vamp plugin initialization

    @uklotzde
    uklotzde committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    8551bff View commit details
    Browse the repository at this point in the history

  2. Connect signal and slot directly 

    ...invoking the slot explicitly by a function call didn't always work
as expected.
    @uklotzde
    uklotzde committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    767bb72 View commit details
    Browse the repository at this point in the history

  3. Rename slots

    @uklotzde
    uklotzde committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    874d498 View commit details
    Browse the repository at this point in the history

  4. Ignore any delayed progress updates

    @uklotzde
    uklotzde committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    934436b View commit details
    Browse the repository at this point in the history

  5. Prefix module statics with "s_"

    @uklotzde
    uklotzde committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    7e9ebd8 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2018

  1. Ensure that the current count and progress never decrease

    @uklotzde
    uklotzde committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    c77a343 View commit details
    Browse the repository at this point in the history

  2. Always unload Vamp plugins through VampPluginLoader

    @uklotzde
    uklotzde committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    9ec1596 View commit details
    Browse the repository at this point in the history

  3. Properly synchronize the initialization of Vamp plugins

    @uklotzde
    uklotzde committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    baf1aac View commit details
    Browse the repository at this point in the history

  4. Fix a potential crash

    @uklotzde
    uklotzde committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    8de5419 View commit details
    Browse the repository at this point in the history

  5. Fix mismatching delete operators

    @uklotzde
    uklotzde committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    3d5f1f2 View commit details
    Browse the repository at this point in the history

  6. Fix progress update algorithm

    @uklotzde
    uklotzde committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    2250b36 View commit details
    Browse the repository at this point in the history

  7. Synchronize access to Vamp plugin functions

    @uklotzde
    uklotzde committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    baed8fd View commit details
    Browse the repository at this point in the history

  8. Fix calculation of current progress (edge cases)

    @uklotzde
    uklotzde committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    325a45c View commit details
    Browse the repository at this point in the history

  9. Add missing Vamp mutex lock

    @uklotzde
    uklotzde committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    b6a6bc5 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2018

  1. Replace VampPluginLoader with thread-safe VampPluginAdapter

    @uklotzde
    uklotzde committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    2990add View commit details
    Browse the repository at this point in the history

  2. Reduce locking in VampPluginAdapter

    @uklotzde
    uklotzde committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    18a67f4 View commit details
    Browse the repository at this point in the history

  3. Revert "Reduce locking in VampPluginAdapter" 

    This reverts commit 18a67f4.
    @uklotzde
    uklotzde committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    1e408c9 View commit details
    Browse the repository at this point in the history

  4. Rename member function

    @uklotzde
    uklotzde committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    daa4819 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2018

  1. Merge branch '2.1' into lp1737537

    @uklotzde
    uklotzde committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    82f48d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. Merge branch '2.1' into lp1737537

    @uklotzde
    uklotzde committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    4820197 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2018

  1. Merge branch '2.1' into lp1737537 

    # Conflicts:
#	src/track/track.cpp
    @uklotzde
    uklotzde committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    8d4facd View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2018

  1. Replace plain pointer with std::unique_ptr

    @uklotzde
    uklotzde committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    9fbc2fa View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. Improve WorkerThread class interface

    @uklotzde
    uklotzde committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    8ab5f8b View commit details
    Browse the repository at this point in the history

  2. Use PerformanceTimer and increase update frequency

    @uklotzde
    uklotzde committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    0dd6859 View commit details
    Browse the repository at this point in the history

  3. Add replay gain analyzers conditionally

    @uklotzde
    uklotzde committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    5a8039e View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2018

  1. Move creation of thread-local db connection closer to usage

    @uklotzde
    uklotzde committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    28b4f10 View commit details
    Browse the repository at this point in the history

  2. Increase size of ring buffer to prevent spin locks

    @uklotzde
    uklotzde committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    8eb72ed View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2018

  1. Replace TrackAnalysisSchedulerPointer with std::unique_ptr

    @uklotzde
    uklotzde committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    48b0b23 View commit details
    Browse the repository at this point in the history

  2. Simplify the design of analysis workers 

    ...by using a dedicated managed pointer for analysis threads that is
now also reusable.
    @uklotzde
    uklotzde committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    2499420 View commit details
    Browse the repository at this point in the history

  3. Store value in temporary variable to improve readability

    @uklotzde
    uklotzde committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    751e1cd View commit details
    Browse the repository at this point in the history

  4. Rename parameters and members

    @uklotzde
    uklotzde committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    fbce3ab View commit details
    Browse the repository at this point in the history

  5. Explain adjustments while calculating amortized analysis progress

    @uklotzde
    uklotzde committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    b7a8ba1 View commit details
    Browse the repository at this point in the history

  6. Merge branch '2.1' into lp1737537

    @uklotzde
    uklotzde committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    4f533cb View commit details
    Browse the repository at this point in the history

  7. Improve the worker thread interface by renaming and documentation

    @uklotzde
    uklotzde committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    5a2401c View commit details
    Browse the repository at this point in the history

  8. Fix incomplete renaming of member function 

    ...caused by naming conflict with QThread::exec().
    @uklotzde
    uklotzde committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    102d283 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2018

  1. Improve naming and documentation

    @uklotzde
    uklotzde committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    2b02e51 View commit details
    Browse the repository at this point in the history

  2. Fix ControlValueAtomic issues

    @uklotzde
    uklotzde committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    012f035 View commit details
    Browse the repository at this point in the history

  3. Add a destructive read operation for ControlValueAtomic 

    ...to ensure that no valid track pointers remain in the ring buffer,
preventing the corresponding track objects from being saved and deleted.
    @uklotzde
    uklotzde committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    4866738 View commit details
    Browse the repository at this point in the history

  4. Reduce size of ring buffer for atomic value

    @uklotzde
    uklotzde committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    55900a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2018

  1. Merge branch '2.1' into lp1737537 

    # Conflicts:
#	src/widget/woverview.cpp
    @uklotzde
    uklotzde committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    0bf89d6 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2018

  1. Merge branch '2.1' into lp1737537

    @uklotzde
    uklotzde committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    34e811e View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2018

  1. Merge branch '2.1' of https://github.com/mixxxdj/mixxx.git into lp173… 

    …7537
    @uklotzde
    uklotzde committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    0169573 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2018

  1. Merge branch '2.1' of https://github.com/mixxxdj/mixxx.git into devel… 

    …opment

# Conflicts:
#	src/mixer/playermanager.cpp
    @uklotzde
    uklotzde committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    b3596d3 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2018

  1. Merge branch '2.1' into lp1737537

    @uklotzde
    uklotzde committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    8502b90 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2018

  1. Fix invocation args of pasuspender

    @uklotzde
    uklotzde committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    17f3ef6 View commit details
    Browse the repository at this point in the history

  2. Merge branch '2.1' of git@github.com:mixxxdj/mixxx.git into lp1737537

    @uklotzde
    uklotzde committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    29a7711 View commit details
    Browse the repository at this point in the history

  3. Fix remaining invocations with of pasuspender

    @uklotzde
    uklotzde committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    2714327 View commit details
    Browse the repository at this point in the history

  4. fix debug assert using empty pixmap source

    @daschuer
    daschuer committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    cc34144 View commit details
    Browse the repository at this point in the history

  5. Fix false postive restart request when changing skin.

    @daschuer
    daschuer committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    920a00b View commit details
    Browse the repository at this point in the history

  6. Fix unresponsive scrolling through crates & playlists with encoder

    @uklotzde
    uklotzde committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    360f988 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2018

  1. Add Gemini to USB rules list

    @Pegasus-RPG
    Pegasus-RPG committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    bc0bd79 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1616 from uklotzde/lp1763007_pasuspender_usage 

    lp1763007: Fix invocation args of pasuspender
    @daschuer
    daschuer authored Apr 17, 2018
    Configuration menu
    Copy the full SHA
    4eb23c3 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1619 from uklotzde/lp1719474_fix_scrolling_throug… 

    …h_crates_and_playlists

lp1719474: Fix unresponsive scrolling through crates & playlists using encoder
    @daschuer
    daschuer authored Apr 17, 2018
    Configuration menu
    Copy the full SHA
    34b0a82 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1618 from daschuer/211bugfixes 

    debug assert fix + lp745679 false poisitiv restart request
    @uklotzde
    uklotzde authored Apr 17, 2018
    Configuration menu
    Copy the full SHA
    cfe067f View commit details
    Browse the repository at this point in the history

  5. Merge branch '2.1' into lp1737537

    @uklotzde
    uklotzde committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    c0448f4 View commit details
    Browse the repository at this point in the history